Bug 18734 – REGRESSION (r31081): Focus problems in Gmail 2/Plain text message text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ruben Bakker]

Summary:
When replying to a message in Gmail 2 using "Plain text" message text, focus will be lost when moving the mouse out of the message text. Only the first character typed will be entered at the beginning of the text, all others will appear at the end of the reply.

Steps to Reproduce: 
1. Log into gmail http://mail.google.com (make sure you have the new version (Gmail 2))
2. Compose a new message and click "Plain text", Gmail will set "Plain text" as your default
3. Cancel the new message to go back to your inbox
4. Open a conversation in your inbox
5. Click into the reply field to reply to the message
6. Before typing, move the mouse out of the message text - the caret will become invisible
7. Type some characters

Expected Results:
Focus remains in the message text, all characters are entered correctly

Actual Results:
- The first character will appear correctly all other characters will go to the end of the message
- The caret should stay visible in the reply field

Regression:
- Happens with Gmail 2 (the newer version)
- The problem can only be duplicated with "Plain text", "Rich text" works

Notes:
- The problem was introduced with ChangeSet http://trac.webkit.org/projects/webkit/changeset/31081 - by undoing this change, focus works correctly.
- The bug has been duplicated with WebKit 32531

[David Kilzer (:ddkilzer)]

Confirmed with WebKit nightly build r32531.  Works correctly with Safari 3.1.1 on Mac OS X Leopard.

Thanks for the great bug report, Ruben, and finding where this regressed!

[David Kilzer (:ddkilzer)]

<rdar://problem/5892415>

[Darin Adler]

I have a fix for this in my tree. Need to make some regression tests now.

[Darin Adler]

Created attachment 25993 [details]
patch in progress -- needs regression tests

[Ruben Bakker]

(In reply to comment #4)
> Created an attachment (id=25993) [review]
> patch in progress -- needs regression tests
> 
I am the bug reporter: I am not sure if you addressed me by this comment :)

BTW: There is a similar focus bug with Gmail 2/Rich text, someone reported this bug: https://bugs.webkit.org/show_bug.cgi?id=14925

[Darin Adler]

(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=25993) [review] [review]
> > patch in progress -- needs regression tests
>
> I am the bug reporter: I am not sure if you addressed me by this comment :)

Nope. I'm going to make the regression tests myself. I just can't land the fix without tests. No worries. Nothing for you to do.

> BTW: There is a similar focus bug with Gmail 2/Rich text, someone reported this
> bug: https://bugs.webkit.org/show_bug.cgi?id=14925

OK. That's got a different cause.

[Darin Adler]

Created attachment 26005 [details]
patch

Comment on attachment 26005 [details]
patch

> +    ta.selectionStart = 3;
> +    ta.selectionEnd = 4;
> +    debug("- set selection so we can test again without a trailing newline");

For consistency with the other steps, you can print the debug message before performing the action.

r=me

[Darin Adler]

http://trac.webkit.org/changeset/39281