Bug 187339 – [GTK][WPE] Remove soup/DownloadSoupErrors.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Rob Buis]

This seems unused.

[Rob Buis]

Created attachment 344323 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 344323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344323&action=review

> Source/WebKit/ChangeLog:7
> +

nit: Maybe just mentioned that the header is not used here.

> Source/WebKit/PlatformGTK.cmake:-372
> -    "${WEBKIT_DIR}/NetworkProcess/Downloads/soup"

Can you do the same for PlatformWPE, please?

[Rob Buis]

Created attachment 344325 [details]
Patch

[Rob Buis]

(In reply to Frédéric Wang (:fredw) from comment #2)
> Comment on attachment 344323 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344323&action=review
> 
> > Source/WebKit/ChangeLog:7
> > +
> 
> nit: Maybe just mentioned that the header is not used here.

Done.

> > Source/WebKit/PlatformGTK.cmake:-372
> > -    "${WEBKIT_DIR}/NetworkProcess/Downloads/soup"
> 
> Can you do the same for PlatformWPE, please?

Sure thing, done.

[Frédéric Wang (:fredw)]

Comment on attachment 344325 [details]
Patch

Thanks!

[Carlos Garcia Campos]

Comment on attachment 344325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344325&action=review

Thanks

> Source/WebKit/ChangeLog:3
> +        [GTK] Remove soup/DownloadSoupErrors.h

This is not GTK specific, either use [GTK][WPE] or [Soup]

> Source/WebKit/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

You don't really need to ask for review to remove this :-)

[WebKit Commit Bot]

Comment on attachment 344325 [details]
Patch

Clearing flags on attachment: 344325

Committed r233518: <https://trac.webkit.org/changeset/233518>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.