Bug 187338 – [JSC] Remove getTypedArrayImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Remove getTypedArrayImpl

[Yusuke Suzuki]

Created attachment 344314 [details]
Patch

[EWS Watchlist]

Attachment 344314 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:309:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 344314 [details]
Patch

Attachment 344314 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8443412

New failing tests:
animations/needs-layout.html

[EWS Watchlist]

Created attachment 344318 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 344314 [details]
Patch

Attachment 344314 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8443507

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 344320 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Yusuke Suzuki]

Ping?

[Mark Lam]

Comment on attachment 344314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review

r=me.

> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315
> +        ASSERT_NOT_REACHED();
> +        return nullptr;

You should make this a RELEASE_ASSERT_NOT_REACHED().  It's the equivalent of JSCell::getTypedArrayImpl() that is now removed.

[Yusuke Suzuki]

Comment on attachment 344314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315
>> +        return nullptr;
> 
> You should make this a RELEASE_ASSERT_NOT_REACHED().  It's the equivalent of JSCell::getTypedArrayImpl() that is now removed.

Nice, fixed.

[Yusuke Suzuki]

Committed r233721: <https://trac.webkit.org/changeset/233721>

[Radar WebKit Bug Importer]

<rdar://problem/42056288>