Bug 187338 - [JSC] Remove getTypedArrayImpl
Summary: [JSC] Remove getTypedArrayImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-05 02:59 PDT by Yusuke Suzuki
Modified: 2018-07-10 22:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.88 KB, patch)
2018-07-05 03:01 PDT, Yusuke Suzuki 		mark.lam: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.37 MB, application/zip)
2018-07-05 05:02 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews206 for win-future (12.78 MB, application/zip)
2018-07-05 05:22 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-05 02:59:48 PDT 
[JSC] Remove getTypedArrayImpl
Comment 1 Yusuke Suzuki 2018-07-05 03:01:20 PDT 
Created attachment 344314 [details]
Patch
Comment 2 EWS Watchlist 2018-07-05 03:02:49 PDT 
Attachment 344314 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:309:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-07-05 05:02:19 PDT 
Comment on attachment 344314 [details]
Patch

Attachment 344314 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8443412

New failing tests:
animations/needs-layout.html
Comment 4 EWS Watchlist 2018-07-05 05:02:21 PDT 
Created attachment 344318 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 5 EWS Watchlist 2018-07-05 05:22:22 PDT 
Comment on attachment 344314 [details]
Patch

Attachment 344314 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8443507

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 6 EWS Watchlist 2018-07-05 05:22:33 PDT 
Created attachment 344320 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Yusuke Suzuki 2018-07-10 19:44:45 PDT 
Ping?
Comment 8 Mark Lam 2018-07-10 20:45:13 PDT 
Comment on attachment 344314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review

r=me.

> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315
> +        ASSERT_NOT_REACHED();
> +        return nullptr;

You should make this a RELEASE_ASSERT_NOT_REACHED().  It's the equivalent of JSCell::getTypedArrayImpl() that is now removed.
Comment 9 Yusuke Suzuki 2018-07-10 21:53:17 PDT 
Comment on attachment 344314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315
>> +        return nullptr;
> 
> You should make this a RELEASE_ASSERT_NOT_REACHED().  It's the equivalent of JSCell::getTypedArrayImpl() that is now removed.

Nice, fixed.
Comment 10 Yusuke Suzuki 2018-07-10 22:00:18 PDT 
Committed r233721: <https://trac.webkit.org/changeset/233721>
Comment 11 Radar WebKit Bug Importer 2018-07-10 22:02:15 PDT 
<rdar://problem/42056288>