Bug 187322 – [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Thibault Saunier]

[WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects

[Thibault Saunier]

Created attachment 344288 [details]
Patch

[EWS Watchlist]

Comment on attachment 344288 [details]
Patch

Attachment 344288 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8437569

New failing tests:
animations/needs-layout.html

[EWS Watchlist]

Created attachment 344293 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Fujii Hironori]

Some scripts fails if flatpak is not used.

> $ ./Tools/Scripts/run-webkit-tests --gtk --release --no-new-test-results fast
> Traceback (most recent call last):
>   File "./Tools/Scripts/run-webkit-tests", line 39, in <module>
>     flatpakutils.run_in_sandbox_if_available(sys.argv)
>   File "./Tools/flatpak/flatpakutils.py", line 829, in run_in_sandbox_if_available
>     if not flatpak_runner.clean_args():
>   File "./Tools/flatpak/flatpakutils.py", line 561, in clean_args
>     port = factory.get(self.platform)
>   File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/factory.py", line 135, in get
>     raise NotImplementedError('unsupported platform: "%s"' % port_name)
> NotImplementedError: unsupported platform: "GTK"

[Fujii Hironori]

Comment on attachment 344288 [details]
Patch

I also tested and confirmed it works. I'm not a reviewer. Informal LGTM.

[Fujii Hironori]

Zan fixed.
https://trac.webkit.org/changeset/233511/webkit

[Zan Dobersek]

Missed this bug. Rolled out my change in r233513 since this addresses it properly.
https://trac.webkit.org/changeset/233513/webkit

[WebKit Commit Bot]

Comment on attachment 344288 [details]
Patch

Clearing flags on attachment: 344288

Committed r233514: <https://trac.webkit.org/changeset/233514>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41839155>