Bug 18732 - SQUIRRELFISH: exceptions thrown by native constructors are ignored
Summary: SQUIRRELFISH: exceptions thrown by native constructors are ignored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18624
  Show dependency tree / graph
 
Reported: 2008-04-24 21:45 PDT by Cameron Zwarich (cpst)
Modified: 2008-04-25 01:33 PDT (History)
0 users

See Also:

Attachments
Proposed patch (1.01 KB, patch)
2008-04-24 21:56 PDT, Cameron Zwarich (cpst) 		mjs: review+
Details | Formatted Diff | Diff
Revised proposed patch (1.04 KB, patch)
2008-04-24 22:05 PDT, Cameron Zwarich (cpst) 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-04-24 21:45:01 PDT 
This problem is seen in the JavaScriptCore regression test js1_5/Regress/regress-118849.js. There is only one easy way of fixing this, adding an exception check to op_construct, so hopefully that doesn't regress performance.
Comment 1 Cameron Zwarich (cpst) 2008-04-24 21:56:15 PDT 
Created attachment 20808 [details]
Proposed patch

Here's the natural patch. It fixes the test, and is either a slight speedup on SunSpider or no regression.
Comment 2 Maciej Stachowiak 2008-04-24 21:58:37 PDT 
Comment on attachment 20808 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-04-24 22:05:59 PDT 
Created attachment 20809 [details]
Revised proposed patch

We should do the exception check before writing to any register. The code currently doing the check after writing is incorrect. This version does slightly better on SunSpider, for a pretty definite 0.4% progression.
Comment 4 Maciej Stachowiak 2008-04-24 22:06:46 PDT 
Comment on attachment 20809 [details]
Revised proposed patch

r=me
Comment 5 Oliver Hunt 2008-04-25 01:33:30 PDT 
Landed r 32538