Bug 187318 - Fix some -Wdocumentation warnings in WebKit
Summary: Fix some -Wdocumentation warnings in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-04 02:11 PDT by Tim Horton
Modified: 2018-07-05 15:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.91 KB, patch)
2018-07-04 02:11 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-07-04 02:11:22 PDT 
Fix some -Wdocumentation warnings in WebKit
Comment 1 Tim Horton 2018-07-04 02:11:36 PDT 
Created attachment 344270 [details]
Patch
Comment 2 Tim Horton 2018-07-04 02:12:51 PDT 
The remaining ones are complaining about WKWebView's frequent

@description @link WKWebView @/link is KVO compliant blah blah.

And complains that the @description is empty.
Comment 3 mitz 2018-07-04 07:02:48 PDT 
Comment on attachment 344270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344270&action=review

> Source/WebKit/ChangeLog:13
> +        Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects,
> +        and the doc comments in the deprecated ICU API have some errors.

We should just go back to treating the ICU headers as system headers, and thus exempt from warnings.
Comment 4 mitz 2018-07-04 07:03:50 PDT 
(In reply to mitz from comment #3)
> Comment on attachment 344270 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344270&action=review
> 
> > Source/WebKit/ChangeLog:13
> > +        Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects,
> > +        and the doc comments in the deprecated ICU API have some errors.
> 
> We should just go back to treating the ICU headers as system headers, and
> thus exempt from warnings.

See bug 183355.
Comment 5 WebKit Commit Bot 2018-07-05 15:20:14 PDT 
Comment on attachment 344270 [details]
Patch

Clearing flags on attachment: 344270

Committed r233544: <https://trac.webkit.org/changeset/233544>
Comment 6 WebKit Commit Bot 2018-07-05 15:20:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-07-05 15:21:23 PDT 
<rdar://problem/41866876>