Bug 187315 - Introduce PLATFORM(IOSMAC)
Summary: Introduce PLATFORM(IOSMAC)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-03 22:44 PDT by Tim Horton
Modified: 2018-07-04 02:08 PDT (History)
9 users (show)

See Also:


Attachments
Patch (123.75 KB, patch)
2018-07-03 22:47 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (123.77 KB, patch)
2018-07-03 23:13 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (123.55 KB, patch)
2018-07-03 23:14 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.78 MB, application/zip)
2018-07-04 01:25 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-07-03 22:44:22 PDT
Introduce PLATFORM(IOSMAC)
Comment 1 Tim Horton 2018-07-03 22:47:25 PDT
Created attachment 344262 [details]
Patch
Comment 2 mitz 2018-07-03 22:51:20 PDT
Comment on attachment 344262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344262&action=review

rs=me, one comment below

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:66
> +ENABLE_CONTENT_FILTERING_iosmac = ;

This can be deleted.
Comment 3 mitz 2018-07-03 22:52:10 PDT
Also please make it build :|
Comment 4 Tim Horton 2018-07-03 23:13:10 PDT
Created attachment 344263 [details]
Patch
Comment 5 Tim Horton 2018-07-03 23:14:47 PDT
Created attachment 344264 [details]
Patch
Comment 6 EWS Watchlist 2018-07-04 01:25:33 PDT
Comment on attachment 344264 [details]
Patch

Attachment 344264 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8433783

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 7 EWS Watchlist 2018-07-04 01:25:45 PDT
Created attachment 344268 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 WebKit Commit Bot 2018-07-04 02:06:18 PDT
Comment on attachment 344264 [details]
Patch

Clearing flags on attachment: 344264

Committed r233501: <https://trac.webkit.org/changeset/233501>
Comment 9 WebKit Commit Bot 2018-07-04 02:06:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-07-04 02:08:22 PDT
<rdar://problem/41812846>