Bug 187311 - MeasurementSet should merge last four segments into two if values are identical.
Summary: MeasurementSet should merge last four segments into two if values are identical.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 18:24 PDT by dewei_zhu
Modified: 2018-07-05 16:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.85 KB, patch)
2018-07-03 18:26 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch (9.78 KB, patch)
2018-07-04 03:25 PDT, dewei_zhu
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-07-03 18:24:37 PDT
MeasurementSet should merge last four segments into two if values are identical.
Comment 1 dewei_zhu 2018-07-03 18:26:37 PDT
Created attachment 344252 [details]
Patch
Comment 2 Ryosuke Niwa 2018-07-03 19:31:15 PDT
Comment on attachment 344252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344252&action=review

> Websites/perf.webkit.org/public/v3/models/measurement-set.js:245
> +            if (!segmentationSeries.length || value !== segmentationSeries[segmentationSeries.length - 1].value)

I think it's cleaner to move this logic to addSegment and rename it to addSegmentMergingIdenticalSegments.
The function can then just compare the last value of segmentationSeries and the newly computed value.
Comment 3 dewei_zhu 2018-07-04 03:25:19 PDT
Created attachment 344271 [details]
Patch