The following layout test is flaky on macOS WK1 editing/selection/navigation-clears-editor-state.html Probable cause: Unknown. This test was added in https://trac.webkit.org/changeset/232434/webkit. It looks like it was flaky since the start, but it has become very flaky recently. The test was modified as part of https://trac.webkit.org/changeset/233236/webkit, which may be the culprit. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fnavigation-clears-editor-state.html --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS freed more than 60 documents +FAIL freed fewer than 60 documents PASS successfullyParsed is true TEST COMPLETE
Ugh... conservative GC is hard :(
We can just make the threshold smaller.
Created attachment 344366 [details] patch
Comment on attachment 344366 [details] patch r=me
Created attachment 344367 [details] patch for landing
Comment on attachment 344367 [details] patch for landing Clearing flags on attachment: 344367 Committed r233555: <https://trac.webkit.org/changeset/233555>
All reviewed patches have been landed. Closing bug.
<rdar://problem/41873906>