Bug 187309 - [mac-wk1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure
Summary: [mac-wk1] Layout Test editing/selection/navigation-clears-editor-state.html i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-03 16:25 PDT by Ryan Haddad
Modified: 2018-10-25 09:45 PDT (History)
9 users (show)

See Also:


Attachments
patch (2.27 KB, patch)
2018-07-05 14:23 PDT, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (2.26 KB, patch)
2018-07-05 14:29 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-07-03 16:25:49 PDT
The following layout test is flaky on macOS WK1

editing/selection/navigation-clears-editor-state.html

Probable cause:

Unknown. This test was added in https://trac.webkit.org/changeset/232434/webkit.
It looks like it was flaky since the start, but it has become very flaky recently. The test was modified as part of https://trac.webkit.org/changeset/233236/webkit, which may be the culprit.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fnavigation-clears-editor-state.html

--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS freed more than 60 documents
+FAIL freed fewer than 60 documents
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Ryosuke Niwa 2018-07-03 19:32:12 PDT
Ugh... conservative GC is hard :(
Comment 2 Saam Barati 2018-07-05 11:42:15 PDT
We can just make the threshold smaller.
Comment 3 Saam Barati 2018-07-05 14:23:22 PDT
Created attachment 344366 [details]
patch
Comment 4 Mark Lam 2018-07-05 14:25:36 PDT
Comment on attachment 344366 [details]
patch

r=me
Comment 5 Saam Barati 2018-07-05 14:29:35 PDT
Created attachment 344367 [details]
patch for landing
Comment 6 WebKit Commit Bot 2018-07-05 18:35:38 PDT
Comment on attachment 344367 [details]
patch for landing

Clearing flags on attachment: 344367

Committed r233555: <https://trac.webkit.org/changeset/233555>
Comment 7 WebKit Commit Bot 2018-07-05 18:35:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-05 18:36:21 PDT
<rdar://problem/41873906>