Bug 187302 – [libwebrtc] Allow IP mismatch for local connections on localhost

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Thibault Saunier]

[libwebrtc] Allow IP mismatch for local connections on localhost

[Thibault Saunier]

Created attachment 344219 [details]
Patch

[Thibault Saunier]

Created attachment 344221 [details]
Patch

[youenn fablet]

Change makes sense, I guess it would make sense in the upstream repo as well.
Should we also consider the IPIsAny check?

[Thibault Saunier]

(In reply to youenn fablet from comment #3)
> Change makes sense, I guess it would make sense in the upstream repo as well.

I guess so yes, I will look into that.

> Should we also consider the IPIsAny check?

It is a good question, in the failure I was seeing `desired_addresses` was "any" fwiw. Do you want me to add it or let it the way it is and add it only if required in the future?

[youenn fablet]

Comment on attachment 344221 [details]
Patch

LGTM, let's land it as is for now.
If you have time to upstream this change, please also discuss the IPIsAny point at the same time.

[WebKit Commit Bot]

Comment on attachment 344221 [details]
Patch

Clearing flags on attachment: 344221

Committed r233506: <https://trac.webkit.org/changeset/233506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41821903>

[Thibault Saunier]

Reopening to attach new patch.

[Thibault Saunier]

Created attachment 350350 [details]
Patch

[Thibault Saunier]

This patch was reverted during the last libwebrtc update.

[Alejandro G. Castro]

Comment on attachment 350350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350350&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcpport.cc:-354
> -    RTC_DCHECK(std::find_if(desired_addresses.begin(), desired_addresses.end(),

I think we can use the webkit compilation define WEBRTC_WEBKIT_BUILD, that way we can try to avoid the patch is removed again in the next merge. At least until we can merge upstream.

[Thibault Saunier]

Created attachment 350352 [details]
Patch

[Thibault Saunier]

New version of the patch has been proposed on https://bugs.webkit.org/show_bug.cgi?id=189828 as asked (so we are required to have 1 patch per bug)

[youenn fablet]

(In reply to Thibault Saunier from comment #11)
> This patch was reverted during the last libwebrtc update.

Yes, sorry.
We will need to come up with a better way of keeping these changes in our trunk when resyncing libwebrtc.