WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
187298
Make CallbackMap::invalidate() safe to re-enter
https://bugs.webkit.org/show_bug.cgi?id=187298
Summary
Make CallbackMap::invalidate() safe to re-enter
Chris Dumez
Reported
2018-07-03 13:25:24 PDT
Make CallbackMap::invalidate() safe to re-enter.
Attachments
Patch
(6.38 KB, patch)
2018-07-03 13:39 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(6.34 KB, patch)
2018-07-03 16:26 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-07-03 13:25:38 PDT
<
rdar://problem/41057167
>
Chris Dumez
Comment 2
2018-07-03 13:39:01 PDT
Created
attachment 344209
[details]
Patch
Geoffrey Garen
Comment 3
2018-07-03 16:20:34 PDT
Comment on
attachment 344209
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=344209&action=review
R=me
> Source/WebKit/UIProcess/GenericCallback.h:164 > + HashMap<uint64_t, T> map = WTFMove(callbackMap);
I would use auto here.
Chris Dumez
Comment 4
2018-07-03 16:26:14 PDT
Created
attachment 344239
[details]
Patch
WebKit Commit Bot
Comment 5
2018-07-03 17:05:46 PDT
Comment on
attachment 344239
[details]
Patch Clearing flags on attachment: 344239 Committed
r233488
: <
https://trac.webkit.org/changeset/233488
>
WebKit Commit Bot
Comment 6
2018-07-03 17:05:47 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug