Bug 187298 - Make CallbackMap::invalidate() safe to re-enter
Summary: Make CallbackMap::invalidate() safe to re-enter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-03 13:25 PDT by Chris Dumez
Modified: 2018-07-03 17:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.38 KB, patch)
2018-07-03 13:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2018-07-03 16:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-07-03 13:25:24 PDT 
Make CallbackMap::invalidate() safe to re-enter.
Comment 1 Chris Dumez 2018-07-03 13:25:38 PDT 
<rdar://problem/41057167>
Comment 2 Chris Dumez 2018-07-03 13:39:01 PDT 
Created attachment 344209 [details]
Patch
Comment 3 Geoffrey Garen 2018-07-03 16:20:34 PDT 
Comment on attachment 344209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344209&action=review

R=me

> Source/WebKit/UIProcess/GenericCallback.h:164
> +    HashMap<uint64_t, T> map = WTFMove(callbackMap);

I would use auto here.
Comment 4 Chris Dumez 2018-07-03 16:26:14 PDT 
Created attachment 344239 [details]
Patch
Comment 5 WebKit Commit Bot 2018-07-03 17:05:46 PDT 
Comment on attachment 344239 [details]
Patch

Clearing flags on attachment: 344239

Committed r233488: <https://trac.webkit.org/changeset/233488>
Comment 6 WebKit Commit Bot 2018-07-03 17:05:47 PDT 
All reviewed patches have been landed.  Closing bug.