Bug 187286 - Clean up the layer volatility code and logging
Summary: Clean up the layer volatility code and logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-02 19:48 PDT by Simon Fraser (smfr)
Modified: 2018-07-05 20:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.16 KB, patch)
2018-07-02 19:52 PDT, Simon Fraser (smfr) 		thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.79 MB, application/zip)
2018-07-03 01:18 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-02 19:48:57 PDT 
Clean up the layer volatility code and logging
Comment 1 Simon Fraser (smfr) 2018-07-02 19:52:24 PDT 
Created attachment 344162 [details]
Patch
Comment 2 EWS Watchlist 2018-07-02 19:54:44 PDT 
Attachment 344162 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1443:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:2252:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:672:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1672:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-07-03 01:18:43 PDT 
Comment on attachment 344162 [details]
Patch

Attachment 344162 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8421306

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
Comment 4 EWS Watchlist 2018-07-03 01:18:54 PDT 
Created attachment 344168 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Simon Fraser (smfr) 2018-07-05 20:21:36 PDT 
https://trac.webkit.org/changeset/233479/webkit
Comment 6 Radar WebKit Bug Importer 2018-07-05 20:24:04 PDT 
<rdar://problem/41876717>