Bug 187277 - Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
Summary: Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries()...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2018-07-02 15:59 PDT by John Wilander
Modified: 2018-07-03 11:25 PDT (History)
3 users (show)

See Also:

Patch (10.04 KB, patch)
2018-07-02 16:15 PDT, John Wilander
no flags Details | Formatted Diff | Diff
Patch for landing (9.35 KB, patch)
2018-07-03 10:46 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-07-02 15:59:48 PDT
WebsiteDataStore::getAllStorageAccessEntries() needs to know which page is calling it and get the storage access entries from the associated network process.
Comment 1 Radar WebKit Bug Importer 2018-07-02 16:00:14 PDT
Comment 2 John Wilander 2018-07-02 16:15:49 PDT
Created attachment 344143 [details]
Comment 3 Chris Dumez 2018-07-03 09:08:56 PDT
Comment on attachment 344143 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=344143&action=review


> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:350
> +    if (webView) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:352
> +        if (webPageProxy) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:26
> +#import <WebKit/WKWebView.h>

Can this be forward-declared below like so?
@class WKWebView;

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:269
> +    if (auto* parentView = mainWebView()) {

Should be an early return.
Comment 4 John Wilander 2018-07-03 10:46:32 PDT
Created attachment 344195 [details]
Patch for landing
Comment 5 John Wilander 2018-07-03 10:47:47 PDT
Thanks, Chris! I took action on all your comments.
Comment 6 WebKit Commit Bot 2018-07-03 11:25:42 PDT
Comment on attachment 344195 [details]
Patch for landing

Clearing flags on attachment: 344195

Committed r233468: <https://trac.webkit.org/changeset/233468>
Comment 7 WebKit Commit Bot 2018-07-03 11:25:44 PDT
All reviewed patches have been landed.  Closing bug.