Bug 187277 – Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

WebsiteDataStore::getAllStorageAccessEntries() needs to know which page is calling it and get the storage access entries from the associated network process.

[Radar WebKit Bug Importer]

<rdar://problem/41745510>

[John Wilander]

Created attachment 344143 [details]
Patch

[Chris Dumez]

Comment on attachment 344143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344143&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:350
> +    if (webView) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:352
> +        if (webPageProxy) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:26
> +#import <WebKit/WKWebView.h>

Can this be forward-declared below like so?
@class WKWebView;

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:269
> +    if (auto* parentView = mainWebView()) {

Should be an early return.

[John Wilander]

Created attachment 344195 [details]
Patch for landing

[John Wilander]

Thanks, Chris! I took action on all your comments.

[WebKit Commit Bot]

Comment on attachment 344195 [details]
Patch for landing

Clearing flags on attachment: 344195

Committed r233468: <https://trac.webkit.org/changeset/233468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.