Bug 187253 – [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

This started in recent builds of macOS Mojave. What appears to be happening is that the system spell checker is now returning both grammar and spelling results for the "I have a issue." portion of the test, and our test isn't robust enough to handle this.

[Wenson Hsieh]

Created attachment 344129 [details]
Patch

[Tim Horton]

Comment on attachment 344129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344129&action=review

> Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:228
> +            auto resultsObject = JSValueToObject(context, JSObjectGetPropertyAtIndex(context, resultsArray, resultIndex, nullptr), nullptr);

Someday we should make this use the modern ObjC JSC API.

[Wenson Hsieh]

Comment on attachment 344129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344129&action=review

>> Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:228
>> +            auto resultsObject = JSValueToObject(context, JSObjectGetPropertyAtIndex(context, resultsArray, resultIndex, nullptr), nullptr);
> 
> Someday we should make this use the modern ObjC JSC API.

Sounds good! I'll refactor this the next time I touch add new functionality here, and add a FIXME to remind myself.

[Wenson Hsieh]

Created attachment 344135 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 344135 [details]:

imported/blink/fast/events/click-focus-anchor-no-ring.html bug 187275 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 344135 [details]
Patch for landing

Clearing flags on attachment: 344135

Committed r233439: <https://trac.webkit.org/changeset/233439>

[Radar WebKit Bug Importer]

<rdar://problem/41745021>

[Truitt Savell]

It looks like once r233439 was pushed and fixed the Mojave test, High Sierra began to have a flakey timeout. 

test history:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fspelling%2Fmarkers.html

Example of timeout:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/6423/steps/layout-test/logs/stdio