Bug 187241 - [LFC] Implement preferred minimum width logic.
Summary: [LFC] Implement preferred minimum width logic.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-01 21:48 PDT by zalan
Modified: 2018-07-03 11:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.14 KB, patch)
2018-07-01 22:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.91 MB, application/zip)
2018-07-01 23:57 PDT, EWS Watchlist 		no flags Details
Patch (37.85 KB, patch)
2018-07-02 07:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.69 KB, patch)
2018-07-02 16:46 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (39.76 KB, patch)
2018-07-03 07:46 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-07-01 21:48:44 PDT 
and use it for shrink-to-fit.
Comment 1 zalan 2018-07-01 22:15:06 PDT 
Created attachment 344074 [details]
Patch
Comment 2 EWS Watchlist 2018-07-01 23:56:55 PDT 
Comment on attachment 344074 [details]
Patch

Attachment 344074 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8409408

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 3 EWS Watchlist 2018-07-01 23:57:06 PDT 
Created attachment 344080 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 zalan 2018-07-02 07:56:34 PDT 
Created attachment 344103 [details]
Patch
Comment 5 zalan 2018-07-02 16:46:01 PDT 
Created attachment 344147 [details]
Patch
Comment 6 zalan 2018-07-03 07:46:37 PDT 
Created attachment 344188 [details]
Patch
Comment 7 Antti Koivisto 2018-07-03 10:30:19 PDT 
Comment on attachment 344188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344188&action=review

> Source/WebCore/layout/FormattingContext.h:58
> +    struct MinimumMaximumIntrinsicWidth {

This is bit clunky. Maybe InstrinsicWidthConstraints or something?
Comment 8 zalan 2018-07-03 11:29:45 PDT 
Committed r233469: <https://trac.webkit.org/changeset/233469>
Comment 9 Radar WebKit Bug Importer 2018-07-03 11:31:15 PDT 
<rdar://problem/41784355>