RESOLVED FIXED187238
Clean up some spellchecking code 
https://bugs.webkit.org/show_bug.cgi?id=187238
Summary Clean up some spellchecking code
Wenson Hsieh
Reported 2018-07-01 18:55:07 PDT
Followup to some of Darin's observations in https://bugs.webkit.org/show_bug.cgi?id=187225.
Attachments
Patch (8.63 KB, patch)
2018-07-01 19:11 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Attempt to bisect the WPE build failure (5.24 KB, patch)
2018-07-01 19:44 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Try to fix WPE build (12.09 KB, patch)
2018-07-01 21:35 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.79 MB, application/zip)
2018-07-02 00:42 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-07-01 19:11:30 PDT
Created attachment 344068 [details] Patch
Wenson Hsieh
Comment 2 2018-07-01 19:44:27 PDT
Created attachment 344069 [details] Attempt to bisect the WPE build failure
Wenson Hsieh
Comment 3 2018-07-01 21:35:57 PDT
Created attachment 344072 [details] Try to fix WPE build
EWS Watchlist
Comment 4 2018-07-02 00:42:38 PDT
Comment on attachment 344072 [details] Try to fix WPE build Attachment 344072 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8409664 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 5 2018-07-02 00:42:49 PDT
Created attachment 344082 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 6 2018-07-02 13:57:00 PDT
Comment on attachment 344072 [details] Try to fix WPE build Clearing flags on attachment: 344072 Committed r233434: <https://trac.webkit.org/changeset/233434>
WebKit Commit Bot
Comment 7 2018-07-02 13:57:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.