Bug 187232 - [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
Summary: [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-01 08:08 PDT by Thibault Saunier
Modified: 2018-07-01 16:52 PDT (History)
7 users (show)

See Also:


Attachments
[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner (4.01 KB, patch)
2018-07-01 08:10 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-07-01 08:08:47 PDT
See commit message.
Comment 1 Thibault Saunier 2018-07-01 08:10:11 PDT
Created attachment 344049 [details]
[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner

The place where host tmp folder is mounted changed to /run/host/ we
need to take that into account.

Also explicitely close temporary files as relying on garbage collection to
remove them is a bad idea.

Also minor optimization avoiding to compile regex for each backtrace
retrieval.
Comment 2 WebKit Commit Bot 2018-07-01 16:51:47 PDT
Comment on attachment 344049 [details]
[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner

Clearing flags on attachment: 344049

Committed r233411: <https://trac.webkit.org/changeset/233411>
Comment 3 WebKit Commit Bot 2018-07-01 16:51:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-07-01 16:52:16 PDT
<rdar://problem/41704367>