Bug 187229 - test-webkitpy never rebuilds lldbWebKitTester
Summary: test-webkitpy never rebuilds lldbWebKitTester
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Mac macOS 10.13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-30 19:53 PDT by Daniel Bates
Modified: 2018-07-02 11:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2018-06-30 19:59 PDT, Daniel Bates
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-06-30 19:53:23 PDT
Currently once lldbWebKitTester is built for the active configuration (see script set-webkit-configuration) then it is never rebuilt by test-webkitpy regardless of whether the source for lldbWebKitTester has changed.
Comment 1 Daniel Bates 2018-06-30 19:59:16 PDT
Created attachment 344037 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2018-06-30 21:39:33 PDT
Comment on attachment 344037 [details]
Patch

r=me
Comment 3 Daniel Bates 2018-06-30 23:00:43 PDT
Committed r233407: <https://trac.webkit.org/changeset/233407>
Comment 4 Radar WebKit Bug Importer 2018-06-30 23:01:24 PDT
<rdar://problem/41688400>
Comment 5 Simon Fraser (smfr) 2018-07-02 11:07:44 PDT
Thanks for the fix!