Bug 187228 - [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
Summary: [Cocoa] Google Fonts doesn't work if the user has the requested font locally-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 186316 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-06-30 18:59 PDT by Myles C. Maxfield
Modified: 2018-07-09 23:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.17 KB, patch)
2018-06-30 19:03 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.87 MB, application/zip)
2018-06-30 20:14 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.34 MB, application/zip)
2018-06-30 20:51 PDT, EWS Watchlist 		no flags Details
Patch (10.95 KB, patch)
2018-07-01 21:38 PDT, Myles C. Maxfield 		bfulgham: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.78 MB, application/zip)
2018-07-01 23:35 PDT, EWS Watchlist 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-06-30 18:59:16 PDT 
[Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
Comment 1 Myles C. Maxfield 2018-06-30 19:03:51 PDT 
Created attachment 344034 [details]
Patch
Comment 2 Myles C. Maxfield 2018-06-30 19:04:09 PDT 
<rdar://problem/40967280>
Comment 3 EWS Watchlist 2018-06-30 20:14:57 PDT 
Comment on attachment 344034 [details]
Patch

Attachment 344034 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8400122

New failing tests:
fast/text/user-installed-fonts/local.html
Comment 4 EWS Watchlist 2018-06-30 20:14:59 PDT 
Created attachment 344038 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-06-30 20:51:25 PDT 
Comment on attachment 344034 [details]
Patch

Attachment 344034 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8400165

New failing tests:
fast/text/user-installed-fonts/local.html
Comment 6 EWS Watchlist 2018-06-30 20:51:26 PDT 
Created attachment 344040 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 7 Myles C. Maxfield 2018-07-01 04:53:10 PDT 
The tests aren't actually failing, they just need some rejiggering to move the relevant pieces around the image
Comment 8 Myles C. Maxfield 2018-07-01 21:30:09 PDT 
The new test passes on macOS Mojave and iOS 12 (where the feature is enabled).
Comment 9 Myles C. Maxfield 2018-07-01 21:38:14 PDT 
Created attachment 344073 [details]
Patch
Comment 10 EWS Watchlist 2018-07-01 23:35:08 PDT 
Comment on attachment 344073 [details]
Patch

Attachment 344073 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8409249

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 11 EWS Watchlist 2018-07-01 23:35:20 PDT 
Created attachment 344078 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 Myles C. Maxfield 2018-07-02 02:04:43 PDT 
Failure is unrelated
Comment 13 Brent Fulgham 2018-07-02 12:21:29 PDT 
Comment on attachment 344073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344073&action=review

r=me

> Source/WebCore/ChangeLog:14
> +        doesnât set the ShouldAllowUserInstalledFonts flag. Then, in CSSFontFaceSource::font(), a similar lookup is

Please get rid of this smart quote!

> Source/WebCore/ChangeLog:18
> +        When the CSSFontFaceSourceâs status gets set to Success, that means âthis is the font face source that

âthis

> Source/WebCore/ChangeLog:19
> +        represents the @font-face blockâ but when CSSFontFaceSource::font() returns nullptr, that means âThe font face

blockâ.  and.   âThe

> Source/WebCore/ChangeLog:20
> +        source canât be used for some reasonâ so we then continue searching down the font-family list (and render the

canât be used for some reasonâ
Comment 14 Myles C. Maxfield 2018-07-02 17:15:31 PDT 
Committed r233447: <https://trac.webkit.org/changeset/233447>
Comment 15 Myles C. Maxfield 2018-07-09 23:30:24 PDT 
*** Bug 186316 has been marked as a duplicate of this bug. ***