Bug 187228 – [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed

[Myles C. Maxfield]

Created attachment 344034 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/40967280>

[EWS Watchlist]

Comment on attachment 344034 [details]
Patch

Attachment 344034 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8400122

New failing tests:
fast/text/user-installed-fonts/local.html

[EWS Watchlist]

Created attachment 344038 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 344034 [details]
Patch

Attachment 344034 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8400165

New failing tests:
fast/text/user-installed-fonts/local.html

[EWS Watchlist]

Created attachment 344040 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Myles C. Maxfield]

The tests aren't actually failing, they just need some rejiggering to move the relevant pieces around the image

[Myles C. Maxfield]

The new test passes on macOS Mojave and iOS 12 (where the feature is enabled).

[Myles C. Maxfield]

Created attachment 344073 [details]
Patch

[EWS Watchlist]

Comment on attachment 344073 [details]
Patch

Attachment 344073 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8409249

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 344078 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Myles C. Maxfield]

Failure is unrelated

[Brent Fulgham]

Comment on attachment 344073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344073&action=review

r=me

> Source/WebCore/ChangeLog:14
> +        doesnât set the ShouldAllowUserInstalledFonts flag. Then, in CSSFontFaceSource::font(), a similar lookup is

Please get rid of this smart quote!

> Source/WebCore/ChangeLog:18
> +        When the CSSFontFaceSourceâs status gets set to Success, that means âthis is the font face source that

âthis

> Source/WebCore/ChangeLog:19
> +        represents the @font-face blockâ but when CSSFontFaceSource::font() returns nullptr, that means âThe font face

blockâ.  and.   âThe

> Source/WebCore/ChangeLog:20
> +        source canât be used for some reasonâ so we then continue searching down the font-family list (and render the

canât be used for some reasonâ

[Myles C. Maxfield]

Committed r233447: <https://trac.webkit.org/changeset/233447>

[Myles C. Maxfield]

*** Bug 186316 has been marked as a duplicate of this bug. ***