WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
187224
Fix clang static analyzer warnings: Garbage return value
https://bugs.webkit.org/show_bug.cgi?id=187224
Summary
Fix clang static analyzer warnings: Garbage return value
David Kilzer (:ddkilzer)
Reported
2018-06-30 14:41:44 PDT
Fix clang static analyzer warnings: Garbage return value.
Attachments
Patch v1
(11.60 KB, patch)
2018-06-30 14:47 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-06-30 14:42:08 PDT
<
rdar://problem/41683170
>
David Kilzer (:ddkilzer)
Comment 2
2018-06-30 14:47:25 PDT
Created
attachment 344023
[details]
Patch v1
Eric Carlson
Comment 3
2018-06-30 16:39:03 PDT
Comment on
attachment 344023
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=344023&action=review
> Source/WebCore/platform/mediastream/MediaConstraints.h:245 > ValueType max = capabilityMax;
Ditto
WebKit Commit Bot
Comment 4
2018-06-30 17:06:45 PDT
Comment on
attachment 344023
[details]
Patch v1 Clearing flags on attachment: 344023 Committed
r233403
: <
https://trac.webkit.org/changeset/233403
>
WebKit Commit Bot
Comment 5
2018-06-30 17:06:46 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 6
2018-06-30 17:44:06 PDT
Comment on
attachment 344023
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=344023&action=review
>> Source/WebCore/platform/mediastream/MediaConstraints.h:245 >> ValueType max = capabilityMax; > > Ditto
What did you mean here? Did you want me to change these lines to this? ValueType min { capabilityMin }; ValueType max { capabilityMax };
David Kilzer (:ddkilzer)
Comment 7
2018-06-30 19:13:00 PDT
(In reply to David Kilzer (:ddkilzer) from
comment #6
)
> Comment on
attachment 344023
[details]
> Patch v1 > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=344023&action=review
> > >> Source/WebCore/platform/mediastream/MediaConstraints.h:245 > >> ValueType max = capabilityMax; > > > > Ditto > > What did you mean here? Did you want me to change these lines to this? > > ValueType min { capabilityMin }; > ValueType max { capabilityMax };
Follow-up fix committed here: Committed
r233406
: <
https://trac.webkit.org/changeset/233403
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug