Fix clang static analyzer warnings: Garbage return value.
<rdar://problem/41683170>
Created attachment 344023 [details] Patch v1
Comment on attachment 344023 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review > Source/WebCore/platform/mediastream/MediaConstraints.h:245 > ValueType max = capabilityMax; Ditto
Comment on attachment 344023 [details] Patch v1 Clearing flags on attachment: 344023 Committed r233403: <https://trac.webkit.org/changeset/233403>
All reviewed patches have been landed. Closing bug.
Comment on attachment 344023 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review >> Source/WebCore/platform/mediastream/MediaConstraints.h:245 >> ValueType max = capabilityMax; > > Ditto What did you mean here? Did you want me to change these lines to this? ValueType min { capabilityMin }; ValueType max { capabilityMax };
(In reply to David Kilzer (:ddkilzer) from comment #6) > Comment on attachment 344023 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344023&action=review > > >> Source/WebCore/platform/mediastream/MediaConstraints.h:245 > >> ValueType max = capabilityMax; > > > > Ditto > > What did you mean here? Did you want me to change these lines to this? > > ValueType min { capabilityMin }; > ValueType max { capabilityMax }; Follow-up fix committed here: Committed r233406: <https://trac.webkit.org/changeset/233403>