Bug 187222 – [CMake] build-webkit should be able to enable address sanitizer

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

If I have run 'set-webkit-configuration --asan' then build-webkit should pass -DENABLE_ADDRESS_SANITIZER=ON to CMake, so it actually does something.

[Michael Catanzaro]

Created attachment 344018 [details]
Patch

[Daniel Bates]

Comment on attachment 344018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review

Do we already support ASan building with CMake using script build-jsc? If not, we should fix this up.

> Tools/ChangeLog:7
> +

Please add a description for this change. I liked what you wrote in comment 0.

[Daniel Bates]

Comment on attachment 344018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review

> Tools/Scripts/webkitdirs.pm:2255
> +    determineASanIsEnabled();

It is unnecessary to call this. We should call asanIsEnabled() on the line below (notice it is a function call).

[Michael Catanzaro]

(In reply to Daniel Bates from comment #2)
> Comment on attachment 344018 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344018&action=review
> 
> Do we already support ASan building with CMake using script build-jsc? If
> not, we should fix this up.

We did not, but build-jsc uses buildCMakeProjectOrExit(), which calls generateBuildSystemFromCMakeProject(), which is the function I'm modifying here, so now it will.

> > Tools/ChangeLog:7
> > +
> 
> Please add a description for this change. I liked what you wrote in comment
> 0.

OK.


(In reply to Daniel Bates from comment #3)
> It is unnecessary to call this. We should call asanIsEnabled() on the line
> below (notice it is a function call).

Yes.

[Michael Catanzaro]

Committed r233402: <https://trac.webkit.org/changeset/233402>

[Radar WebKit Bug Importer]

<rdar://problem/41682664>