Bug 187208 – Perl uninitialized value $isEnabled when running build-jsc using a CMake build

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

While looking at the stdio on <http://ews-build.webkit-uat.org/#/builders/17/builds/5/steps/2/logs/stdio>, which builds JSC using CMake, I noticed the following error output:

    Use of uninitialized value in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221.
    Use of uninitialized value $isEnabled in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221.

[Daniel Bates]

Following the patch for bug #177338, we no longer encode a default value for feature flags in webkitperl::FeatureList.

[Daniel Bates]

Created attachment 343978 [details]
Patch

[Daniel Bates]

Can someone save me some time, should we enable enable ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.

[Daniel Bates]

(In reply to Daniel Bates from comment #3)
> Can someone save me some time, should we enable enable
> ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current
> behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.

We may set this feature flag per: <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig?rev=233385#L127>

[Daniel Bates]

(In reply to Daniel Bates from comment #3)
> Can someone save me some time, should we enable enable
> ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current
> behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.

The --no-experimental-features option in build-webkit, added in the patch for bug #177338, is only used by the GTK Linux bots. For now, I am going to keep this bug focused on fixing the uninitialized value error and keep the current behavior of not toggling experimental features when building with CMake.

[Daniel Bates]

Committed r233386: <https://trac.webkit.org/changeset/233386>

[Radar WebKit Bug Importer]

<rdar://problem/41663440>