Bug 187208 - Perl uninitialized value $isEnabled when running build-jsc using a CMake build
Summary: Perl uninitialized value $isEnabled when running build-jsc using a CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-29 17:04 PDT by Daniel Bates
Modified: 2018-06-29 19:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.51 KB, patch)
2018-06-29 17:11 PDT, Daniel Bates
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-06-29 17:04:59 PDT
While looking at the stdio on <http://ews-build.webkit-uat.org/#/builders/17/builds/5/steps/2/logs/stdio>, which builds JSC using CMake, I noticed the following error output:

    Use of uninitialized value in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221.
    Use of uninitialized value $isEnabled in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221.
Comment 1 Daniel Bates 2018-06-29 17:05:37 PDT
Following the patch for bug #177338, we no longer encode a default value for feature flags in webkitperl::FeatureList.
Comment 2 Daniel Bates 2018-06-29 17:11:50 PDT
Created attachment 343978 [details]
Patch
Comment 3 Daniel Bates 2018-06-29 17:13:13 PDT
Can someone save me some time, should we enable enable ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.
Comment 4 Daniel Bates 2018-06-29 18:57:37 PDT
(In reply to Daniel Bates from comment #3)
> Can someone save me some time, should we enable enable
> ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current
> behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.

We may set this feature flag per: <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig?rev=233385#L127>
Comment 5 Daniel Bates 2018-06-29 19:03:59 PDT
(In reply to Daniel Bates from comment #3)
> Can someone save me some time, should we enable enable
> ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current
> behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES.

The --no-experimental-features option in build-webkit, added in the patch for bug #177338, is only used by the GTK Linux bots. For now, I am going to keep this bug focused on fixing the uninitialized value error and keep the current behavior of not toggling experimental features when building with CMake.
Comment 6 Daniel Bates 2018-06-29 19:06:42 PDT
Committed r233386: <https://trac.webkit.org/changeset/233386>
Comment 7 Radar WebKit Bug Importer 2018-06-29 19:07:18 PDT
<rdar://problem/41663440>