Bug 187200 – Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads, in order the simplify the code a little bit.

[Chris Dumez]

Created attachment 343962 [details]
Patch

[Brent Fulgham]

Comment on attachment 343962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review

Looks much tidier! r=me.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86
>      ASSERT(RunLoop::isMain());

We can get rid of this ASSERT here, can't we?

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:96
>      ASSERT(RunLoop::isMain());

Ditto.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:106
>      ASSERT(RunLoop::isMain());

Ditto.

[Chris Dumez]

Comment on attachment 343962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review

>> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86
>>      ASSERT(RunLoop::isMain());
> 
> We can get rid of this ASSERT here, can't we?

It is documenting, I kind of like them.

[EWS Watchlist]

Comment on attachment 343962 [details]
Patch

Attachment 343962 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8388725

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 343971 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

Created attachment 343974 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343974 [details]
Patch

Clearing flags on attachment: 343974

Committed r233381: <https://trac.webkit.org/changeset/233381>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41723818>