WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
187191
[ews-build] Add timeout to webkitpy and webkitperl tests
https://bugs.webkit.org/show_bug.cgi?id=187191
Summary
[ews-build] Add timeout to webkitpy and webkitperl tests
Aakash Jain
Reported
2018-06-29 13:18:27 PDT
There have been occurrences in the past in which webkitpy tests get stuck. In the current system EWS bots get completely stuck (and a manual intervention is required). With buildbot, the build step running the test would be killed by buildbot in 20 minutes. webkitpy and webkitperl tests typically takes 10s. 20 minutes (without any output) is a long time to wait. We should set a smaller timeout (like 2 minutes).
Attachments
Proposed patch
(3.33 KB, patch)
2018-06-29 13:21 PDT
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2018-06-29 13:21:22 PDT
Created
attachment 343935
[details]
Proposed patch Sample runs:
http://ews-build.webkit-uat.org/#/builders/16/builds/7
http://ews-build.webkit-uat.org/#/builders/15/builds/3
EWS Watchlist
Comment 2
2018-06-29 13:23:52 PDT
Comment hidden (obsolete)
Attachment 343935
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:92: [RunWebKitPerlTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:103: [RunWebKitPyTests.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Aakash Jain
Comment 3
2018-06-29 13:26:44 PDT
Committed
r233368
: <
https://trac.webkit.org/changeset/233368
>.
Radar WebKit Bug Importer
Comment 4
2018-06-29 13:27:19 PDT
<
rdar://problem/41649817
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug