[GTK][WPE] api tests are broken with flatpak environment

[Carlos Alberto Lopez Perez]

This happens:


$ Tools/Scripts/run-gtk-tests
Running in sandbox: "flatpak" "build" "--die-with-parent" "--bind-mount=/run/host//tmp=/tmp" "--bind-mount=/app/webkit=/home/clopez/webkit/webkit" "--bind-mount=/app/webkit/WebKitBuild/Release=/home/clopez/webkit/webkit/WebKitBuild/GTK/Release" "--env=LANG=en_US.utf8" "--env=WEBKIT_TOP_LEVEL=/app/" "--env=GTK_MODULES=gail:atk-bridge" "--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/lib/libTestRunnerInjectedBundle.so" "--env=DISPLAY=:0.0" "--share=ipc" "--socket=x11" "--socket=wayland" "--device=all" "--share=network" "--socket=pulseaudio" "--system-talk-name=org.freedesktop.GeoClue2" "--filesystem=host" "--socket=system-bus" "--talk-name=org.freedesktop.Flatpak" "--env=GST_PRESET_PATH=/app/share/gstreamer-1.0/presets/" "/home/clopez/webkit/webkit/WebKitBuild/GTK/FlatpakTreeRelease" "/app/webkit/Tools/Scripts/run-gtk-tests"

Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/run-gtk-tests", line 145, in <module>
    runner = GtkTestRunner(options, args)
  File "/app/webkit/Tools/Scripts/run-gtk-tests", line 40, in __init__
    super(GtkTestRunner, self).__init__("gtk", options, tests)
  File "/app/webkit/Tools/glib/api_test_runner.py", line 47, in __init__
    self._programs_path = common.binary_build_path()
  File "/app/webkit/Tools/glib/common.py", line 62, in binary_build_path
    binary_build_dir = build_path('bin', *args)
  File "/app/webkit/Tools/glib/common.py", line 122, in build_path
    return os.path.join(*(get_build_path(),) + args)
  File "/app/webkit/Tools/glib/common.py", line 89, in get_build_path
    scm = SCMDetector(FileSystem(), Executive()).default_scm()
  File "/app/webkit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 55, in default_scm
    scm_system = self.detect_scm_system(cwd, patch_directories)
  File "/app/webkit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 71, in detect_scm_system
    if SVN.in_working_directory(real_path, executive=self._executive):
  File "/app/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 101, in in_working_directory
    exit_code = executive.run_command(svn_info_args, cwd=path, return_exit_code=True)
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 386, in run_command
    close_fds=self._should_close_fds())
  File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 481, in popen
    return subprocess.Popen(string_args, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Command '['flatpak', 'build', '--die-with-parent', '--bind-mount=/run/host//tmp=/tmp', '--bind-mount=/app/webkit=/home/clopez/webkit/webkit', '--bind-mount=/app/webkit/WebKitBuild/Release=/home/clopez/webkit/webkit/WebKitBuild/GTK/Release', '--env=LANG=en_US.utf8', '--env=WEBKIT_TOP_LEVEL=/app/', '--env=GTK_MODULES=gail:atk-bridge', '--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/lib/libTestRunnerInjectedBundle.so', '--env=DISPLAY=:0.0', '--share=ipc', '--socket=x11', '--socket=wayland', '--device=all', '--share=network', '--socket=pulseaudio', '--system-talk-name=org.freedesktop.GeoClue2', '--filesystem=host', '--socket=system-bus', '--talk-name=org.freedesktop.Flatpak', '--env=GST_PRESET_PATH=/app/share/gstreamer-1.0/presets/', '/home/clopez/webkit/webkit/WebKitBuild/GTK/FlatpakTreeRelease', 'sh', '/run/host//tmp/tmpCAu5xl']' returned non-zero exit status 1

[Thibault Saunier]

Hrm, I tested that at some point, it regressed with newer version of the patch.

[Philippe Normand]

Still valid?

[Philippe Normand]

With the new SDK tests run. Closing :)