r210683 prevents file URLs from being copied to the clipboard in unexpected cases. This behavior should be documented in a test.
Created attachment 343921 [details] Patch
Created attachment 343922 [details] Patch
Comment on attachment 343922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343922&action=review > LayoutTests/TestExpectations:2187 > +webkit.org/b/187183 http/tests/security/pasteboard-file-url.html [ Pass Crash ] It's expected to crash?!
Created attachment 343954 [details] Patch
Discussed with Wenson and Tim - we should not crash. Fixed the behavior and added a test.
<rdar://problem/41656200>
Comment on attachment 343954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343954&action=review > Tools/WebKitTestRunner/TestOptions.h:75 > bool hasSameInitializationOptions(const TestOptions& options) const This will definitely work, but I think it's a bit confusing to have a helper named "hasSameInitializationOptions" if it may return false for two identical TestOptions that both have the runSingly flag. I think this would be a bit less misleading if we: - Check that options.runSingly matches in hasSameInitializationOptions - And also return `!options.runSingly && m_options.hasSameInitializationOptions(options)` from the call site in viewSupportsOptions
Created attachment 343961 [details] Patch
Comment on attachment 343961 [details] Patch Clearing flags on attachment: 343961 Committed r233379: <https://trac.webkit.org/changeset/233379>
All reviewed patches have been landed. Closing bug.