Bug 187175 - [WPE] Some frames are dropped when using rAF to animate an element
Summary: [WPE] Some frames are dropped when using rAF to animate an element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-29 05:00 PDT by Miguel Gomez
Modified: 2018-07-01 22:36 PDT (History)
4 users (show)

See Also:

Attachments
testcase (1.14 KB, text/html)
2018-06-29 05:00 PDT, Miguel Gomez 		no flags Details
Patch (2.92 KB, patch)
2018-06-29 05:43 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-06-29 05:00:26 PDT 
Created attachment 343907 [details]
testcase

There's a certain situation using rAF to animate an alement where the sequence of frames rendered is not the right, which causes the animation to be flickery. I'm attaching a testcase where the problem can be reproduced.

The problem is that instead of rendering the frames in the appropriate order
1-2-3-4-5-6
we're rendering
1-1-2-4-4-5-7-7

and this happens because we're triggering schedules in the ThreadedCompositor that should wait for a pending layerFlush and it's not.
Comment 1 Miguel Gomez 2018-06-29 05:43:17 PDT 
Created attachment 343910 [details]
Patch
Comment 2 WebKit Commit Bot 2018-06-29 06:52:30 PDT 
Comment on attachment 343910 [details]
Patch

Clearing flags on attachment: 343910

Committed r233353: <https://trac.webkit.org/changeset/233353>
Comment 3 WebKit Commit Bot 2018-06-29 06:52:32 PDT 
All reviewed patches have been landed.  Closing bug.