Bug 187164 - Find in page for typographic quotes does not find low (German) quotes
Summary: Find in page for typographic quotes does not find low (German) quotes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-28 17:01 PDT by Olivia Barnett
Modified: 2018-06-28 20:02 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.24 KB, patch)
2018-06-28 17:16 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (6.26 KB, patch)
2018-06-28 17:45 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (6.37 KB, patch)
2018-06-28 17:56 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivia Barnett 2018-06-28 17:01:51 PDT 
Find in page for typographic quotes does not find straight quotes
Comment 1 Olivia Barnett 2018-06-28 17:16:51 PDT 
Created attachment 343874 [details]
Patch
Comment 2 Tim Horton 2018-06-28 17:18:59 PDT 
Comment on attachment 343874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343874&action=review

> Source/WebCore/editing/TextIterator.cpp:1780
> +    string.replace(leftLowDoubleQuotationMark, '"');

Are there no /right/ low quotes?
Comment 3 Olivia Barnett 2018-06-28 17:19:23 PDT 
<rdar://problem/29612785>
Comment 4 Olivia Barnett 2018-06-28 17:21:25 PDT 
I looked here and didn't find any "right" low quotation marks. https://en.wikipedia.org/wiki/Quotation_mark#Unicode_code_point_table

I think in German it is low then high.
Comment 5 Tim Horton 2018-06-28 17:22:04 PDT 
Comment on attachment 343874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343874&action=review

> Source/WTF/ChangeLog:3
> +        Find in page for typographic quotes does not find straight quotes

I think this title is about something different than what you're fixing, right? This is about curly vs. straight, which seems like it already works, maybe?
Comment 6 Olivia Barnett 2018-06-28 17:29:25 PDT 
Yeah, you are right -- that functionality works. For some reason this was the radar post name even though the bug seems different. Should I change the name?
Comment 7 Tim Horton 2018-06-28 17:32:11 PDT 
(In reply to Olivia Barnett from comment #6)
> Yeah, you are right -- that functionality works. For some reason this was
> the radar post name even though the bug seems different. Should I change the
> name?

Definitely!
Comment 8 Olivia Barnett 2018-06-28 17:45:56 PDT 
Created attachment 343877 [details]
Patch
Comment 9 Tim Horton 2018-06-28 17:47:11 PDT 
Comment on attachment 343877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343877&action=review

> Source/WTF/ChangeLog:5
> +

Radar URL should go on the line below the bugs.webkit.org URL.
Comment 10 Olivia Barnett 2018-06-28 17:56:48 PDT 
Created attachment 343878 [details]
Patch
Comment 11 WebKit Commit Bot 2018-06-28 18:19:58 PDT 
Comment on attachment 343878 [details]
Patch

Clearing flags on attachment: 343878

Committed r233345: <https://trac.webkit.org/changeset/233345>
Comment 12 WebKit Commit Bot 2018-06-28 18:19:59 PDT 
All reviewed patches have been landed.  Closing bug.