Bug 187164 – Find in page for typographic quotes does not find low (German) quotes

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Olivia Barnett]

Find in page for typographic quotes does not find straight quotes

[Olivia Barnett]

Created attachment 343874 [details]
Patch

[Tim Horton]

Comment on attachment 343874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343874&action=review

> Source/WebCore/editing/TextIterator.cpp:1780
> +    string.replace(leftLowDoubleQuotationMark, '"');

Are there no /right/ low quotes?

[Olivia Barnett]

<rdar://problem/29612785>

[Olivia Barnett]

I looked here and didn't find any "right" low quotation marks. https://en.wikipedia.org/wiki/Quotation_mark#Unicode_code_point_table

I think in German it is low then high.

[Tim Horton]

Comment on attachment 343874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343874&action=review

> Source/WTF/ChangeLog:3
> +        Find in page for typographic quotes does not find straight quotes

I think this title is about something different than what you're fixing, right? This is about curly vs. straight, which seems like it already works, maybe?

[Olivia Barnett]

Yeah, you are right -- that functionality works. For some reason this was the radar post name even though the bug seems different. Should I change the name?

[Tim Horton]

(In reply to Olivia Barnett from comment #6)
> Yeah, you are right -- that functionality works. For some reason this was
> the radar post name even though the bug seems different. Should I change the
> name?

Definitely!

[Olivia Barnett]

Created attachment 343877 [details]
Patch

[Tim Horton]

Comment on attachment 343877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343877&action=review

> Source/WTF/ChangeLog:5
> +

Radar URL should go on the line below the bugs.webkit.org URL.

[Olivia Barnett]

Created attachment 343878 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343878 [details]
Patch

Clearing flags on attachment: 343878

Committed r233345: <https://trac.webkit.org/changeset/233345>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.