187149 – Add sandbox to microdone plugin

RESOLVED FIXED 187149

Add sandbox to microdone plugin

https://bugs.webkit.org/show_bug.cgi?id=187149

Summary Add sandbox to microdone plugin

youenn fablet

Reported 2018-06-28 11:57:20 PDT

Add sandbox to microdone plugin

Attachments
Patch (6.72 KB, patch) 2018-06-28 12:00 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Adding .sb to the sandbox file (4.10 KB, patch) 2018-07-02 16:38 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing sandbox filename (10.34 KB, patch) 2018-07-02 17:08 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-06-28 11:58:18 PDT

<rdar://problem/41538057>

youenn fablet

Comment 2 2018-06-28 12:00:07 PDT

Created attachment 343829 [details] Patch

Brent Fulgham

Comment 3 2018-06-28 12:02:32 PDT

Comment on attachment 343829 [details] Patch r=me

WebKit Commit Bot

Comment 4 2018-06-28 12:42:30 PDT

Comment on attachment 343829 [details] Patch Clearing flags on attachment: 343829 Committed r233317: <https://trac.webkit.org/changeset/233317>

WebKit Commit Bot

Comment 5 2018-06-28 12:42:32 PDT

All reviewed patches have been landed. Closing bug.

youenn fablet

Comment 6 2018-07-02 16:38:05 PDT

Reopening to attach new patch.

youenn fablet

Comment 7 2018-07-02 16:38:06 PDT

Created attachment 344144 [details] Adding .sb to the sandbox file

WebKit Commit Bot

Comment 8 2018-07-02 17:07:34 PDT

Comment on attachment 344144 [details] Adding .sb to the sandbox file Rejecting attachment 344144 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: mb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles error: /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari: No such file or directory PBXCp Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles PBXCp /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/com.apple.WebKit.plugin-common.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb cd /Volumes/Data/EWS/WebKit/Source/WebKit builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/com.apple.WebKit.plugin-common.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles ** BUILD FAILED ** The following build commands failed: PBXCp Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari (1 failure) Full output: https://webkit-queues.webkit.org/results/8417942

youenn fablet

Comment 9 2018-07-02 17:08:54 PDT

Created attachment 344154 [details] Fixing sandbox filename

WebKit Commit Bot

Comment 10 2018-07-02 17:34:49 PDT

Comment on attachment 344154 [details] Fixing sandbox filename Clearing flags on attachment: 344154 Committed r233450: <https://trac.webkit.org/changeset/233450>

WebKit Commit Bot

Comment 11 2018-07-02 17:34:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Plug-ins

Assignee

youenn fablet

Reported

2018-06-28 11:57 PDT

Modified

2018-07-02 17:34 PDT History

CC List

3 users Show

URL

Keywords InRadar

Depends on

Blocks