Bug 187149 - Add sandbox to microdone plugin
Summary: Add sandbox to microdone plugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-28 11:57 PDT by youenn fablet
Modified: 2018-07-02 17:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.72 KB, patch)
2018-06-28 12:00 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Adding .sb to the sandbox file (4.10 KB, patch)
2018-07-02 16:38 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Fixing sandbox filename (10.34 KB, patch)
2018-07-02 17:08 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-06-28 11:57:20 PDT
Add sandbox to microdone plugin
Comment 1 youenn fablet 2018-06-28 11:58:18 PDT
<rdar://problem/41538057>
Comment 2 youenn fablet 2018-06-28 12:00:07 PDT
Created attachment 343829 [details]
Patch
Comment 3 Brent Fulgham 2018-06-28 12:02:32 PDT
Comment on attachment 343829 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-28 12:42:30 PDT
Comment on attachment 343829 [details]
Patch

Clearing flags on attachment: 343829

Committed r233317: <https://trac.webkit.org/changeset/233317>
Comment 5 WebKit Commit Bot 2018-06-28 12:42:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 youenn fablet 2018-07-02 16:38:05 PDT
Reopening to attach new patch.
Comment 7 youenn fablet 2018-07-02 16:38:06 PDT
Created attachment 344144 [details]
Adding .sb to the sandbox file
Comment 8 WebKit Commit Bot 2018-07-02 17:07:34 PDT
Comment on attachment 344144 [details]
Adding .sb to the sandbox file

Rejecting attachment 344144 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
mb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles
error: /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari: No such file or directory

PBXCp Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.QuickTime\ Plugin.plugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebKit/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

PBXCp /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/com.apple.WebKit.plugin-common.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb
    cd /Volumes/Data/EWS/WebKit/Source/WebKit
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/com.apple.WebKit.plugin-common.sb /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles

** BUILD FAILED **


The following build commands failed:
	PBXCp Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari
(1 failure)

Full output: https://webkit-queues.webkit.org/results/8417942
Comment 9 youenn fablet 2018-07-02 17:08:54 PDT
Created attachment 344154 [details]
Fixing sandbox filename
Comment 10 WebKit Commit Bot 2018-07-02 17:34:49 PDT
Comment on attachment 344154 [details]
Fixing sandbox filename

Clearing flags on attachment: 344154

Committed r233450: <https://trac.webkit.org/changeset/233450>
Comment 11 WebKit Commit Bot 2018-07-02 17:34:50 PDT
All reviewed patches have been landed.  Closing bug.