Add the first unit test for dump_class_layout
Created attachment 343809 [details] Patch
Attachment 343809 [details] did not pass style-queue: ERROR: Tools/lldb/lldb_dump_class_layout.py:41: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/lldb/dump_class_layout_unittest.py:39: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 343809 [details] Patch Attachment 343809 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8370663 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Created attachment 343815 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343809&action=review > Tools/lldb/lldb_dump_class_layout.py:146 > + target = debugger.CreateTargetWithFileAndArch(str(self.binary_path), architecture) I had issues using this API and switched to CreateTarget(). I take it the issues have since been resolved. See <rdar://problem/39960149> for more details.
Fixing via 185801. *** This bug has been marked as a duplicate of bug 185801 ***