<rdar://problem/41014117>
Created attachment 343794 [details] Patch
Created attachment 343796 [details] Patch
Comment on attachment 343796 [details] Patch Attachment 343796 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8368322 New failing tests: http/tests/preload/onload_event.html
Created attachment 343805 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343796&action=review > Source/WebCore/dom/DataTransferItemList.cpp:143 > + for (auto& file : m_dataTransfer.files().files()) Why do we need to check this given filesFromPasteboardAndItemList already check this condition? > Source/WebCore/platform/PasteboardItemInfo.h:43 > + bool hasDeclaredNonTextType { false }; Can we just say isNonTextType? It seems rather wordy to say "has declared". > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:162 > + // The preferred presentation style is the most direct indication of whether this item represents file- I think this comment is redundant with the one long description above. Remove?
Comment on attachment 343796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343796&action=review >> Source/WebCore/dom/DataTransferItemList.cpp:143 >> + for (auto& file : m_dataTransfer.files().files()) > > Why do we need to check this given filesFromPasteboardAndItemList already check this condition? Good catch — we don't need this since the other check already ensures that DataTransfer.files() is empty. Removed! >> Source/WebCore/platform/PasteboardItemInfo.h:43 >> + bool hasDeclaredNonTextType { false }; > > Can we just say isNonTextType? It seems rather wordy to say "has declared". Done! >> Source/WebCore/platform/cocoa/PasteboardCocoa.mm:162 >> + // The preferred presentation style is the most direct indication of whether this item represents file- > > I think this comment is redundant with the one long description above. Remove? Sounds good! Removed.
Created attachment 343869 [details] Patch for landing
Comment on attachment 343869 [details] Patch for landing Clearing flags on attachment: 343869 Committed r233339: <https://trac.webkit.org/changeset/233339>