Bug 18713 - Inconcistent painting of scrollbars when hovered and sunken
Summary: Inconcistent painting of scrollbars when hovered and sunken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P3 Normal
Assignee: Tor Arne Vestbø
URL: http://code.staikos.net/cgi-bin/gitwe...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 06:30 PDT by Tor Arne Vestbø
Modified: 2008-04-28 03:13 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.69 KB, patch)
2008-04-25 08:10 PDT, Tor Arne Vestbø
hausmann: review-
Details | Formatted Diff | Diff
Updated patch (4.28 KB, patch)
2008-04-28 02:25 PDT, Tor Arne Vestbø
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2008-04-24 06:30:49 PDT
Observable only on Vista, since that's the only style that paints scrollbars diffrently for hovered and sunken states, but easily reproducable with a patch to the plastique style. 

1. First time hover paints hover-state, but any hover after that does not.
2. Click on a scollbar paints sunken state, but moving the mouse away from the scrollbar while still pressing down goes back to painting hovered state, instead of keeping the sunken state.
Comment 1 Tor Arne Vestbø 2008-04-25 07:54:16 PDT
Fixed in http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=torarne/scrollbar-paint-fix and integrated into the qtwebkit branch. 

Comment 2 Tor Arne Vestbø 2008-04-25 08:09:25 PDT
Adding patch for review
Comment 3 Tor Arne Vestbø 2008-04-25 08:10:59 PDT
Created attachment 20819 [details]
Patch
Comment 4 Simon Hausmann 2008-04-28 00:02:08 PDT
Looks good to me, but there's a break; missing after the call to d->leaveEvent() in qwebpage.cpp :)
Comment 5 Tor Arne Vestbø 2008-04-28 02:25:14 PDT
Created attachment 20862 [details]
Updated patch
Comment 6 Simon Hausmann 2008-04-28 02:52:30 PDT
Comment on attachment 20862 [details]
Updated patch

Thanks :)
Comment 7 Simon Hausmann 2008-04-28 03:13:47 PDT
Landed in r32613