Bug 187119 - Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.println to print.
Summary: Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-27 15:18 PDT by Mark Lam
Modified: 2018-06-27 16:14 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (13.36 KB, patch)
2018-06-27 15:22 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-06-27 15:18:54 PDT 
I also renamed some other "print" functions to use "dump" instead to match their underlying C++ code that they will call e.g. CodeBlock::dumpSource().
Comment 1 Mark Lam 2018-06-27 15:22:24 PDT 
Created attachment 343761 [details]
proposed patch.
Comment 2 Keith Miller 2018-06-27 15:33:26 PDT 
Comment on attachment 343761 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2018-06-27 15:34:04 PDT 
Comment on attachment 343761 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 WebKit Commit Bot 2018-06-27 16:14:00 PDT 
Comment on attachment 343761 [details]
proposed patch.

Clearing flags on attachment: 343761

Committed r233285: <https://trac.webkit.org/changeset/233285>
Comment 5 WebKit Commit Bot 2018-06-27 16:14:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-27 16:14:39 PDT 
<rdar://problem/41550102>