Bug 187112 - Add some more register state information when we crash in repatchPutById
Summary: Add some more register state information when we crash in repatchPutById
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-27 12:48 PDT by Saam Barati
Modified: 2018-06-27 17:19 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.22 KB, patch)
2018-06-27 15:08 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch (1.61 KB, patch)
2018-06-27 16:04 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-06-27 12:48:26 PDT 
...
Comment 1 Saam Barati 2018-06-27 15:08:13 PDT 
Created attachment 343756 [details]
patch
Comment 2 Mark Lam 2018-06-27 15:14:10 PDT 
Comment on attachment 343756 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343756&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:590
> +                        if (offset != conditionSetOffset) {

Add UNLIKELY() around the condition?
Comment 3 Saam Barati 2018-06-27 16:04:36 PDT 
Created attachment 343764 [details]
patch
Comment 4 WebKit Commit Bot 2018-06-27 17:18:57 PDT 
Comment on attachment 343764 [details]
patch

Clearing flags on attachment: 343764

Committed r233291: <https://trac.webkit.org/changeset/233291>
Comment 5 WebKit Commit Bot 2018-06-27 17:18:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-27 17:19:26 PDT 
<rdar://problem/41553229>