Bug 187106 - Add logging to try to diagnose where we get a null structure.
Summary: Add logging to try to diagnose where we get a null structure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-27 10:59 PDT by Keith Miller
Modified: 2018-06-27 14:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2018-06-27 11:09 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (3.83 KB, patch)
2018-06-27 11:38 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-sierra (480.67 KB, application/zip)
2018-06-27 12:39 PDT, WebKit Commit Bot 		no flags Details
Patch for landing (3.91 KB, patch)
2018-06-27 13:33 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-06-27 10:59:20 PDT 
Add logging to try to diagnose where we get a null structure.
Comment 1 Keith Miller 2018-06-27 11:09:59 PDT 
Created attachment 343729 [details]
Patch
Comment 2 Mark Lam 2018-06-27 11:31:37 PDT 
Comment on attachment 343729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343729&action=review

r=me with additional ChangeLog comment.

> Source/JavaScriptCore/ChangeLog:9
> +        Add a logging to JSObject::toPrimitive to help diagnose a nullptr
> +        structure crash.

Can you please add a note that this logging is disabled by default, and requires a code change + rebuild to enable it?
Comment 3 Keith Miller 2018-06-27 11:38:36 PDT 
Created attachment 343732 [details]
Patch for landing
Comment 4 Mark Lam 2018-06-27 11:42:48 PDT 
(In reply to Mark Lam from comment #2)
> Can you please add a note that this logging is disabled by default, and
> requires a code change + rebuild to enable it?

I was wrong about this.  Keith pointed out (offline) that this is not disabled by default, hence why this code is only here temporarily, and need to be removed eventually.
Comment 5 WebKit Commit Bot 2018-06-27 12:39:10 PDT 
Comment on attachment 343732 [details]
Patch for landing

Rejecting attachment 343732 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: https://webkit-queues.webkit.org/results/8361086
Comment 6 WebKit Commit Bot 2018-06-27 12:39:11 PDT 
Created attachment 343740 [details]
Archive of layout-test-results from webkit-cq-01 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Keith Miller 2018-06-27 13:33:00 PDT 
Created attachment 343748 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-06-27 14:26:53 PDT 
Comment on attachment 343748 [details]
Patch for landing

Clearing flags on attachment: 343748

Committed r233278: <https://trac.webkit.org/changeset/233278>
Comment 9 WebKit Commit Bot 2018-06-27 14:26:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-06-27 14:29:31 PDT 
<rdar://problem/41543626>