The following layout test is flaky on macOS js/error-should-not-strong-reference-global-object.html Probable cause: Unknown, this test was flaky when landed, a fix was landed, now the text diff has changed. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Ferror-should-not-strong-reference-global-object.html --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/js/error-should-not-strong-reference-global-object-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/js/error-should-not-strong-reference-global-object-actual.txt @@ -1,4 +1,5 @@ -PASS successfullyParsed is true +CONSOLE MESSAGE: line 48: Error: There are more global objects than there should be: actual count = 2654 +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE
This test is also frequently timing out on Sierra Debug WK2.
Created attachment 343936 [details] Patch
Created attachment 343940 [details] Mark test as flaky
Comment on attachment 343940 [details] Mark test as flaky Clearing flags on attachment: 343940 Committed r233369: <https://trac.webkit.org/changeset/233369>
This test is also a flaky failure on iOS Simulator Debug: --- /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/js/error-should-not-strong-reference-global-object-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/js/error-should-not-strong-reference-global-object-actual.txt @@ -1,4 +1,5 @@ -PASS successfullyParsed is true +CONSOLE MESSAGE: line 48: Error: There are more global objects than there should be: actual count = 51 +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE