Bug 187085 - [JSC] Remove ArrayPatternNode::emitDirectBinding()
Summary: [JSC] Remove ArrayPatternNode::emitDirectBinding()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on: 185943
Blocks: 268026
  Show dependency tree / graph
 
Reported: 2018-06-26 23:57 PDT by Yusuke Suzuki
Modified: 2024-02-28 16:33 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-06-26 23:57:13 PDT 
Since it does not follow array spreading protocol.
Comment 1 Alexey Shvayka 2024-01-30 14:25:01 PST 
Related test262 failures:
  * test/language/statements/const/dstr/ary-init-iter-get-err-array-prototype.js
  * test/language/statements/const/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js
  * test/language/statements/for/dstr/const-ary-init-iter-get-err-array-prototype.js
  * test/language/statements/for/dstr/const-ary-ptrn-elem-id-iter-val-array-prototype.js
  * test/language/statements/for/dstr/let-ary-init-iter-get-err-array-prototype.js
  * test/language/statements/for/dstr/let-ary-ptrn-elem-id-iter-val-array-prototype.js
  * test/language/statements/for/dstr/var-ary-init-iter-get-err-array-prototype.js
  * test/language/statements/for/dstr/var-ary-ptrn-elem-id-iter-val-array-prototype.js
  * test/language/statements/let/dstr/ary-init-iter-get-err-array-prototype.js
  * test/language/statements/let/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js
  * test/language/statements/variable/dstr/ary-init-iter-get-err-array-prototype.js
  * test/language/statements/variable/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js
Comment 2 Radar WebKit Bug Importer 2024-01-30 14:25:23 PST 
<rdar://problem/121959952>
Comment 3 Alexey Shvayka 2024-02-26 16:37:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25143
Comment 4 EWS 2024-02-28 16:33:29 PST 
Committed 275474@main (76811693b100): <https://commits.webkit.org/275474@main>

Reviewed commits have been landed. Closing PR #25143 and removing active labels.