Bug 187078 - [GTK][WPE] Remove gflags from libwebrtc build
Summary: [GTK][WPE] Remove gflags from libwebrtc build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-26 19:34 PDT by Yusuke Suzuki
Modified: 2018-06-27 01:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2018-06-26 19:37 PDT, Yusuke Suzuki 		alex: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-06-26 19:34:17 PDT 
[GTK][WPE] Remove gflags from libwebrtc build
Comment 1 Yusuke Suzuki 2018-06-26 19:37:07 PDT 
Created attachment 343679 [details]
Patch
Comment 2 Alejandro G. Castro 2018-06-27 01:02:59 PDT 
Comment on attachment 343679 [details]
Patch

LGTM, if bots are happy it is great we can avoid that.
Comment 3 Yusuke Suzuki 2018-06-27 01:17:43 PDT 
Thanks!

mac and ios bots are unrelated since they do not use CMake. They failed with transient errors (connection to git.webkit.org is timing out).
gtk-wk2 becomes green. So, I think it is OK.
Comment 4 Yusuke Suzuki 2018-06-27 01:19:10 PDT 
Committed r233249: <https://trac.webkit.org/changeset/233249>
Comment 5 Radar WebKit Bug Importer 2018-06-27 01:20:45 PDT 
<rdar://problem/41512519>