Bug 187077 - When trying to print a very long email on iOS, the print preview is blank
Summary: When trying to print a very long email on iOS, the print preview is blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-26 19:27 PDT by Tim Horton
Modified: 2018-07-02 11:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2018-06-26 19:27 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-06-26 19:27:26 PDT
When trying to print a very long email on iOS, the print preview is blank
Comment 1 Tim Horton 2018-06-26 19:27:36 PDT
Created attachment 343677 [details]
Patch
Comment 2 Tim Horton 2018-06-26 19:27:48 PDT
rdar://problem/41107013
Comment 3 WebKit Commit Bot 2018-06-27 01:27:47 PDT
Comment on attachment 343677 [details]
Patch

Clearing flags on attachment: 343677

Committed r233250: <https://trac.webkit.org/changeset/233250>
Comment 4 WebKit Commit Bot 2018-06-27 01:27:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2018-06-28 09:13:23 PDT
Comment on attachment 343677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343677&action=review

> Source/WebKit/ChangeLog:11
> +        ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,

Should we now also change that default to either "no default" or to "infinity" for clarity?
Comment 6 Tim Horton 2018-07-02 11:57:26 PDT
(In reply to Darin Adler from comment #5)
> Comment on attachment 343677 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343677&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +        ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,
> 
> Should we now also change that default to either "no default" or to
> "infinity" for clarity?

Probably infinity, since everything else defaults to that, but it's a bit scary. I filed https://bugs.webkit.org/show_bug.cgi?id=187259.