Bug 18707 - SQUIRRELFISH: eval always performs toString() on its argument
Summary: SQUIRRELFISH: eval always performs toString() on its argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18624
  Show dependency treegraph
 
Reported: 2008-04-23 22:06 PDT by Cameron Zwarich (cpst)
Modified: 2008-04-23 22:35 PDT (History)
0 users

See Also:


Attachments
Proposed patch (1.03 KB, patch)
2008-04-23 22:19 PDT, Cameron Zwarich (cpst)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-04-23 22:06:33 PDT
The following JavaScriptCore tests fail because eval always performs toString() on its argument, instead of returning the argument verbatim if it is not a string:

ecma/GlobalObject/15.1.2.1-1.js
ecma/NativeObjects/15-2.js
ecma/Number/15.7.3.1-2.js
ecma/ObjectObjects/15.2.3-1.js
Comment 1 Cameron Zwarich (cpst) 2008-04-23 22:19:59 PDT
Created attachment 20785 [details]
Proposed patch

Here is a patch that fixes the problem. It shows no difference on SunSpider.
Comment 2 Maciej Stachowiak 2008-04-23 22:27:30 PDT
Comment on attachment 20785 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-04-23 22:35:52 PDT
Committed in r32459.