Bug 187065 - Deal better with the network process crashing on startup
Summary: Deal better with the network process crashing on startup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-26 15:16 PDT by Chris Dumez
Modified: 2018-06-26 19:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.69 KB, patch)
2018-06-26 15:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-26 15:16:38 PDT 
When a network process crashes on startup, we would not attempt to relaunch it. If there were web processes waiting for a connection to this network process, we would send them an invalid connection identifier which would cause them to forcefully crash.
Instead, we now apply the same policy whether a network process crashes on startup or later:
- We attempt to relaunch the network process
- If there were pending connections from WebContent processes, we send them the conn
Comment 1 Chris Dumez 2018-06-26 15:17:32 PDT 
<rdar://problem/41451622>
Comment 2 Chris Dumez 2018-06-26 15:22:25 PDT 
Created attachment 343647 [details]
Patch
Comment 3 Geoffrey Garen 2018-06-26 18:39:29 PDT 
Comment on attachment 343647 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-26 19:11:05 PDT 
Comment on attachment 343647 [details]
Patch

Clearing flags on attachment: 343647

Committed r233240: <https://trac.webkit.org/changeset/233240>
Comment 5 WebKit Commit Bot 2018-06-26 19:11:06 PDT 
All reviewed patches have been landed.  Closing bug.