Bug 187056 – webkit-patch: Make attachment commands work with status-server hosted attachments

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

We should teach "webkit-patch apply-attachment" and other attachment-processing commands (*) how to fetch attachments from the status server when it cannot access them from Bugzilla due to a permission error. Note that the status server will only allow a person to fetch such attachments with a valid API key.

(*) apply-watchlist, build-attachment, build-and-test-attachment, check-style and land-attachment

[Daniel Bates]

Although a human being can make use of these commands to work with status-server hosted attachments the primary audience for this change are the EWS bots. The EWS bots invoke webkit-patch to perform attachment operations.

[Daniel Bates]

Created attachment 343625 [details]
Patch and unit test

[EWS Watchlist]

Comment on attachment 343625 [details]
Patch and unit test

Attachment 343625 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8350076

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 343633 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Per Arne Vollan]

Comment on attachment 343625 [details]
Patch and unit test

R=me.

[Daniel Bates]

Comment on attachment 343625 [details]
Patch and unit test

Clearing flags on attachment: 343625

Committed r233219: <https://trac.webkit.org/changeset/233219>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41489194>