Bug 187033 - [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
Summary: [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-25 23:20 PDT by Zan Dobersek
Modified: 2018-06-27 01:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.32 KB, patch)
2018-06-25 23:30 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.85 MB, application/zip)
2018-06-26 11:13 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-06-25 23:20:14 PDT 
[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
Comment 1 Zan Dobersek 2018-06-25 23:30:55 PDT 
Created attachment 343587 [details]
Patch
Comment 2 Michael Catanzaro 2018-06-26 08:28:57 PDT 
Comment on attachment 343587 [details]
Patch

r=me since this is clearly an improvement.

I'm not thrilled about have a bunch of free functions inside the WebCore namespace, outside any class or other namespace. It would be nice if these functions were inside some additional namespace.
Comment 3 EWS Watchlist 2018-06-26 11:13:04 PDT 
Comment on attachment 343587 [details]
Patch

Attachment 343587 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8348613

New failing tests:
http/tests/preload/onload_event.html
Comment 4 EWS Watchlist 2018-06-26 11:13:16 PDT 
Created attachment 343624 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Zan Dobersek 2018-06-27 01:13:13 PDT 
Comment on attachment 343587 [details]
Patch

Clearing flags on attachment: 343587

Committed r233247: <https://trac.webkit.org/changeset/233247>
Comment 6 Zan Dobersek 2018-06-27 01:13:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-27 01:15:17 PDT 
<rdar://problem/41512431>