RESOLVED FIXED 187033
[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file 
https://bugs.webkit.org/show_bug.cgi?id=187033
Summary [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
Zan Dobersek
Reported 2018-06-25 23:20:14 PDT
[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
Attachments
Patch (16.32 KB, patch)
2018-06-25 23:30 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.85 MB, application/zip)
2018-06-26 11:13 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-06-25 23:30:55 PDT
Created attachment 343587 [details] Patch
Michael Catanzaro
Comment 2 2018-06-26 08:28:57 PDT
Comment on attachment 343587 [details] Patch r=me since this is clearly an improvement. I'm not thrilled about have a bunch of free functions inside the WebCore namespace, outside any class or other namespace. It would be nice if these functions were inside some additional namespace.
EWS Watchlist
Comment 3 2018-06-26 11:13:04 PDT
Comment on attachment 343587 [details] Patch Attachment 343587 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8348613 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 4 2018-06-26 11:13:16 PDT
Created attachment 343624 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Zan Dobersek
Comment 5 2018-06-27 01:13:13 PDT
Comment on attachment 343587 [details] Patch Clearing flags on attachment: 343587 Committed r233247: <https://trac.webkit.org/changeset/233247>
Zan Dobersek
Comment 6 2018-06-27 01:13:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-06-27 01:15:17 PDT
<rdar://problem/41512431>
Note You need to log in before you can comment on or make changes to this bug.