Bug 187026 - Web Inspector: Color picker: can't enter decimal numbers for opacity
Summary: Web Inspector: Color picker: can't enter decimal numbers for opacity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-25 16:50 PDT by Nikita Vasilyev
Modified: 2018-08-23 21:55 PDT (History)
5 users (show)

See Also:


Attachments
[Video] Bug (2.54 MB, video/quicktime)
2018-06-25 16:50 PDT, Nikita Vasilyev
no flags Details
Patch (3.75 KB, patch)
2018-08-23 11:08 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2018-08-23 21:17 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-25 16:50:41 PDT
Created attachment 343558 [details]
[Video] Bug

1. Add "color: hsla(0, 0%, 0%, 0.5)" color property
2. Click on the black square before "hsla(0, 0%, 0%, 0.5)" to display the color picker
3. Click on the last text field, "A"
4. Place text caret after "0.5"
5. Press delete

Expected:
The opacity text field shows "0.|"

Actual:
The opacity text field shows "0|". Furthermore, pressing delete again doesn't remove "0"!

Notes:
Also, Up and Down keys only increment between 0 and 1.
Comment 1 Radar WebKit Bug Importer 2018-06-25 16:51:36 PDT
<rdar://problem/41446500>
Comment 2 Devin Rousso 2018-08-23 11:08:13 PDT
Created attachment 347939 [details]
Patch
Comment 3 Brian Burg 2018-08-23 16:52:12 PDT
Comment on attachment 347939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347939&action=review

r=me

> Source/WebInspectorUI/ChangeLog:12
> +        (WI.ColorPicker.prototype._handleColorInputInput):

Please explain why this change fixes the problem. It's not obvious.
Comment 4 Devin Rousso 2018-08-23 21:17:59 PDT
Created attachment 347987 [details]
Patch
Comment 5 WebKit Commit Bot 2018-08-23 21:55:35 PDT
Comment on attachment 347987 [details]
Patch

Clearing flags on attachment: 347987

Committed r235273: <https://trac.webkit.org/changeset/235273>
Comment 6 WebKit Commit Bot 2018-08-23 21:55:36 PDT
All reviewed patches have been landed.  Closing bug.