Bug 187022 - Remove RELEASE_ASSERT added in r230875
Summary: Remove RELEASE_ASSERT added in r230875
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-25 16:13 PDT by Brady Eidson
Modified: 2018-06-25 16:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2018-06-25 16:19 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-06-25 16:13:42 PDT 
Remove RELEASE_ASSERT added in r230875

https://trac.webkit.org/changeset/230875/webkit

Turns out it's hit a lot.

Not terribly surprising as there's more than one way a session can be destroyed unpredictably while a web socket might have just asynchronously started its handshake!

<rdar://problem/40860061>
Comment 1 Brady Eidson 2018-06-25 16:19:10 PDT 
Created attachment 343553 [details]
Patch
Comment 2 Brent Fulgham 2018-06-25 16:21:21 PDT 
Comment on attachment 343553 [details]
Patch

Looks great! r=me
Comment 3 Brent Fulgham 2018-06-25 16:21:36 PDT 
Comment on attachment 343553 [details]
Patch

Looks great! r=me.
Comment 4 WebKit Commit Bot 2018-06-25 16:56:07 PDT 
Comment on attachment 343553 [details]
Patch

Clearing flags on attachment: 343553

Committed r233183: <https://trac.webkit.org/changeset/233183>
Comment 5 WebKit Commit Bot 2018-06-25 16:56:09 PDT 
All reviewed patches have been landed.  Closing bug.