Bug 187011 - [iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
Summary: [iPad apps on macOS] Web process crashes when attempting to play embedded You...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-25 13:02 PDT by Wenson Hsieh
Modified: 2018-06-26 07:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2018-06-25 13:22 PDT, Wenson Hsieh 		thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.20 KB, patch)
2018-06-25 14:47 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.76 MB, application/zip)
2018-06-25 15:15 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-06-25 13:02:10 PDT 
<rdar://problem/40906808>
Comment 1 Wenson Hsieh 2018-06-25 13:22:16 PDT 
Created attachment 343529 [details]
Patch
Comment 2 Tim Horton 2018-06-25 13:41:46 PDT 
Comment on attachment 343529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343529&action=review

> Source/WebCore/platform/RemoteCommandListener.cpp:31
> +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR)

In the ideal world this would become something like HAS(MEDIAREMOTE)
Comment 3 Wenson Hsieh 2018-06-25 14:26:38 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 343529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343529&action=review
> 
> > Source/WebCore/platform/RemoteCommandListener.cpp:31
> > +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR)
> 
> In the ideal world this would become something like HAS(MEDIAREMOTE)

Good point. It looks like HAVE(MEDIA_PLAYER) already exists, and it's closer to what I should be switching on for this bug. I'll change this to use that instead.
Comment 4 Wenson Hsieh 2018-06-25 14:47:02 PDT 
Created attachment 343544 [details]
Patch for landing
Comment 5 EWS Watchlist 2018-06-25 15:15:44 PDT 
Comment on attachment 343529 [details]
Patch

Attachment 343529 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8337342

New failing tests:
http/tests/preload/onload_event.html
Comment 6 EWS Watchlist 2018-06-25 15:15:56 PDT 
Created attachment 343548 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 WebKit Commit Bot 2018-06-25 16:54:37 PDT 
Comment on attachment 343544 [details]
Patch for landing

Clearing flags on attachment: 343544

Committed r233182: <https://trac.webkit.org/changeset/233182>