Bug 187011 – [iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wenson Hsieh]

<rdar://problem/40906808>

[Wenson Hsieh]

Created attachment 343529 [details]
Patch

[Tim Horton]

Comment on attachment 343529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343529&action=review

> Source/WebCore/platform/RemoteCommandListener.cpp:31
> +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR)

In the ideal world this would become something like HAS(MEDIAREMOTE)

[Wenson Hsieh]

(In reply to Tim Horton from comment #2)
> Comment on attachment 343529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343529&action=review
> 
> > Source/WebCore/platform/RemoteCommandListener.cpp:31
> > +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR)
> 
> In the ideal world this would become something like HAS(MEDIAREMOTE)

Good point. It looks like HAVE(MEDIA_PLAYER) already exists, and it's closer to what I should be switching on for this bug. I'll change this to use that instead.

[Wenson Hsieh]

Created attachment 343544 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 343529 [details]
Patch

Attachment 343529 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8337342

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 343548 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 343544 [details]
Patch for landing

Clearing flags on attachment: 343544

Committed r233182: <https://trac.webkit.org/changeset/233182>