Bug 186997 – [Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

The HTML5 event loop mandates that animations are updated prior to requestAnimationFrame callbacks being fired. We need to implement this if only to reduce test flakiness since some tests use a rAF callback to check that animations have been updated. This is needed to fix https://bugs.webkit.org/show_bug.cgi?id=183826.

[Radar WebKit Bug Importer]

<rdar://problem/41419414>

[Radar WebKit Bug Importer]

<rdar://problem/41419416>

[Antoine Quint]

Committed r233140: <https://trac.webkit.org/changeset/233140>

[David Kilzer (:ddkilzer)]

(In reply to Antoine Quint from comment #3)
> Committed r233140: <https://trac.webkit.org/changeset/233140>

Attempt to fix Windows build failure:

Committed r233144: <https://trac.webkit.org/changeset/233144>

[Dawei Fenton (:realdawei)]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to Antoine Quint from comment #3)
> > Committed r233140: <https://trac.webkit.org/changeset/233140>
> 
> Attempt to fix Windows build failure:
> 
> Committed r233144: <https://trac.webkit.org/changeset/233144>

unfortunately Windows is still failing to build:

Sample error:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/5228/steps/layout-test/logs/stdio

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\dom/Document.cpp(2448): error C2027: use of undefined type 'WebCore::DocumentAnimationScheduler' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource206.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\dom\Document.h(83): note: see declaration of 'WebCore::DocumentAnimationScheduler' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource206.cpp)

[Ross Kirsling]

The first error before r233144 was
> WebCore\dom/Document.cpp(2448): error C2027: use of undefined type 'WebCore::DocumentAnimationScheduler'

The first error after r233144 is now
> WebCore\animation/KeyframeEffectReadOnly.cpp(707): error C2027: use of undefined type 'WebCore::FrameView'

[Ross Kirsling]

Looks like DocumentAnimationScheduler really is an undefined type on Windows:
- https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Platform.h#L1138-L1140
- https://github.com/WebKit/webkit/blob/master/Source/WebCore/animation/DocumentAnimationScheduler.h#L28

So I think r233144 could be reversed in favor of three extra #ifs in Document.cpp (unless we wanted to make a stub implementation).

[David Kilzer (:ddkilzer)]

(In reply to Ross Kirsling from comment #7)
> Looks like DocumentAnimationScheduler really is an undefined type on Windows:
> -
> https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Platform.h#L1138-
> L1140
> -
> https://github.com/WebKit/webkit/blob/master/Source/WebCore/animation/
> DocumentAnimationScheduler.h#L28
> 
> So I think r233144 could be reversed in favor of three extra #ifs in
> Document.cpp (unless we wanted to make a stub implementation).

Thanks!  Just landed:

Committed r233163: <https://trac.webkit.org/changeset/233163>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #8)
> (In reply to Ross Kirsling from comment #7)
> > Looks like DocumentAnimationScheduler really is an undefined type on Windows:
> > -
> > https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Platform.h#L1138-
> > L1140
> > -
> > https://github.com/WebKit/webkit/blob/master/Source/WebCore/animation/
> > DocumentAnimationScheduler.h#L28
> > 
> > So I think r233144 could be reversed in favor of three extra #ifs in
> > Document.cpp (unless we wanted to make a stub implementation).
> 
> Thanks!  Just landed:
> 
> Committed r233163: <https://trac.webkit.org/changeset/233163>

And:

Committed r233170: < https://trac.webkit.org/changeset/233170>

[Ross Kirsling]

(In reply to David Kilzer (:ddkilzer) from comment #9)
> (In reply to David Kilzer (:ddkilzer) from comment #8)
> > (In reply to Ross Kirsling from comment #7)
> > > Looks like DocumentAnimationScheduler really is an undefined type on Windows:
> > > -
> > > https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Platform.h#L1138-
> > > L1140
> > > -
> > > https://github.com/WebKit/webkit/blob/master/Source/WebCore/animation/
> > > DocumentAnimationScheduler.h#L28
> > > 
> > > So I think r233144 could be reversed in favor of three extra #ifs in
> > > Document.cpp (unless we wanted to make a stub implementation).
> > 
> > Thanks!  Just landed:
> > 
> > Committed r233163: <https://trac.webkit.org/changeset/233163>
> 
> And:
> 
> Committed r233170: < https://trac.webkit.org/changeset/233170>

You beat me to the punch. :)
Apparently KeyframeEffectReadOnly.cpp had a legitimate separate issue, but builds should go green after this one.