Bug 186976 - Web Inspector: Dark Mode: Box Model section should have dark background
Summary: Web Inspector: Dark Mode: Box Model section should have dark background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-23 15:54 PDT by Nikita Vasilyev
Modified: 2018-06-25 17:45 PDT (History)
5 users (show)

See Also:


Attachments
[Screenshot] Bug (22.71 KB, image/png)
2018-06-23 15:54 PDT, Nikita Vasilyev
no flags Details
Patch (2.53 KB, patch)
2018-06-23 16:46 PDT, Nikita Vasilyev
bburg: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
[Animated GIF] With patch applied (31.10 KB, image/gif)
2018-06-23 16:46 PDT, Nikita Vasilyev
no flags Details
Archive of layout-test-results from ews206 for win-future (12.77 MB, application/zip)
2018-06-23 19:58 PDT, EWS Watchlist
no flags Details
Patch (2.53 KB, patch)
2018-06-25 17:03 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-23 15:54:29 PDT
Created attachment 343455 [details]
[Screenshot] Bug

Currently, Box Model section in the dark mode looks the same as in the light mode.
Instead, it should have dark background and light text.
Comment 1 Nikita Vasilyev 2018-06-23 16:46:30 PDT
Created attachment 343459 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-23 16:46:53 PDT
Created attachment 343460 [details]
[Animated GIF] With patch applied
Comment 3 EWS Watchlist 2018-06-23 19:58:13 PDT
Comment on attachment 343459 [details]
Patch

Attachment 343459 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8309142

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-06-23 19:58:24 PDT
Created attachment 343465 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 BJ Burg 2018-06-25 08:42:47 PDT
Comment on attachment 343459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343459&action=review

> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:739
> +    .details-section .row.box-model {

Why is this not going into BoxModelDetailsSectionRow.css directly? I'd prefer that; move any dependent variables into Variables.css if you need to.
Comment 6 BJ Burg 2018-06-25 08:43:15 PDT
r=me
Comment 7 WebKit Commit Bot 2018-06-25 10:36:04 PDT
Comment on attachment 343459 [details]
Patch

Rejecting attachment 343459 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 343459, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343459&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186976&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 343459 from bug 186976.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343459
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 0ab3844283f700303726c9503c2650947d5ea062 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5682717aad0f391c97228b3ed673d684bcc3da72 a2681699d78b4c7395df539914b7a2f757ffd3ec M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 0ab3844283f700303726c9503c2650947d5ea062 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5682717aad0f391c97228b3ed673d684bcc3da72 a2681699d78b4c7395df539914b7a2f757ffd3ec M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   e8c2ac794dc..c39d86fa311  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 233151 = e8c2ac794dc6a1fb95b25ab315965bec65da3c12
r233152 = c39d86fa311caec11ddd2630bbf4f7efef143b7f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/8332245
Comment 8 Nikita Vasilyev 2018-06-25 17:03:58 PDT
Created attachment 343560 [details]
Patch
Comment 9 WebKit Commit Bot 2018-06-25 17:43:39 PDT
Comment on attachment 343560 [details]
Patch

Clearing flags on attachment: 343560

Committed r233187: <https://trac.webkit.org/changeset/233187>
Comment 10 WebKit Commit Bot 2018-06-25 17:43:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-06-25 17:45:08 PDT
<rdar://problem/41448533>