Bug 186976 – Web Inspector: Dark Mode: Box Model section should have dark background

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 343455 [details]
[Screenshot] Bug

Currently, Box Model section in the dark mode looks the same as in the light mode.
Instead, it should have dark background and light text.

[Nikita Vasilyev]

Created attachment 343459 [details]
Patch

[Nikita Vasilyev]

Created attachment 343460 [details]
[Animated GIF] With patch applied

[EWS Watchlist]

Comment on attachment 343459 [details]
Patch

Attachment 343459 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8309142

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 343465 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Blaze Burg]

Comment on attachment 343459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343459&action=review

> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:739
> +    .details-section .row.box-model {

Why is this not going into BoxModelDetailsSectionRow.css directly? I'd prefer that; move any dependent variables into Variables.css if you need to.

[Blaze Burg]

r=me

[WebKit Commit Bot]

Comment on attachment 343459 [details]
Patch

Rejecting attachment 343459 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 343459, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343459&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186976&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 343459 from bug 186976.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343459
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 0ab3844283f700303726c9503c2650947d5ea062 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5682717aad0f391c97228b3ed673d684bcc3da72 a2681699d78b4c7395df539914b7a2f757ffd3ec M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 0ab3844283f700303726c9503c2650947d5ea062 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5682717aad0f391c97228b3ed673d684bcc3da72 a2681699d78b4c7395df539914b7a2f757ffd3ec M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   e8c2ac794dc..c39d86fa311  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 233151 = e8c2ac794dc6a1fb95b25ab315965bec65da3c12
r233152 = c39d86fa311caec11ddd2630bbf4f7efef143b7f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/8332245

[Nikita Vasilyev]

Created attachment 343560 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 343560 [details]
Patch

Clearing flags on attachment: 343560

Committed r233187: <https://trac.webkit.org/changeset/233187>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41448533>