Bug 186975 - Web Inspector: Dark Mode: color outline is too dark
Summary: Web Inspector: Dark Mode: color outline is too dark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-23 15:43 PDT by Nikita Vasilyev
Modified: 2018-06-25 10:45 PDT (History)
4 users (show)

See Also:

Attachments
[Screenshot] Bug (16.25 KB, image/png)
2018-06-23 15:43 PDT, Nikita Vasilyev 		no flags Details
Patch (1.21 KB, patch)
2018-06-23 15:46 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Screenshot] With patch applied (16.51 KB, image/png)
2018-06-23 15:47 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-23 15:43:38 PDT 
Created attachment 343452 [details]
[Screenshot] Bug

When hovering a color declaration in CSS, e.g. #000, the outline is so dark that it's hardly visible.
Comment 1 Nikita Vasilyev 2018-06-23 15:46:35 PDT 
Created attachment 343453 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-23 15:47:09 PDT 
Created attachment 343454 [details]
[Screenshot] With patch applied
Comment 3 BJ Burg 2018-06-25 10:10:04 PDT 
Comment on attachment 343453 [details]
Patch

Shouldn't this be using the focus ring color? I am not a fan of that gray outline if a caret selection will always look different from it.
Comment 4 Nikita Vasilyev 2018-06-25 10:33:17 PDT 
(In reply to Brian Burg from comment #3)
> Comment on attachment 343453 [details]
> Patch
> 
> Shouldn't this be using the focus ring color? I am not a fan of that gray
> outline if a caret selection will always look different from it.

This outline is only visible when hovering (with a mouse cursor).
The focus ring may be shown elsewhere.
Comment 5 BJ Burg 2018-06-25 10:36:40 PDT 
Comment on attachment 343453 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-06-25 10:42:09 PDT 
Comment on attachment 343453 [details]
Patch

Clearing flags on attachment: 343453

Committed r233156: <https://trac.webkit.org/changeset/233156>
Comment 7 WebKit Commit Bot 2018-06-25 10:42:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-25 10:45:42 PDT 
<rdar://problem/41429310>