RESOLVED FIXED 186975
Web Inspector: Dark Mode: color outline is too dark 
https://bugs.webkit.org/show_bug.cgi?id=186975
Summary Web Inspector: Dark Mode: color outline is too dark
Nikita Vasilyev
Reported 2018-06-23 15:43:38 PDT
Created attachment 343452 [details] [Screenshot] Bug When hovering a color declaration in CSS, e.g. #000, the outline is so dark that it's hardly visible.
Attachments
[Screenshot] Bug (16.25 KB, image/png)
2018-06-23 15:43 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.21 KB, patch)
2018-06-23 15:46 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Screenshot] With patch applied (16.51 KB, image/png)
2018-06-23 15:47 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-06-23 15:46:35 PDT
Created attachment 343453 [details] Patch
Nikita Vasilyev
Comment 2 2018-06-23 15:47:09 PDT
Created attachment 343454 [details] [Screenshot] With patch applied
Blaze Burg
Comment 3 2018-06-25 10:10:04 PDT
Comment on attachment 343453 [details] Patch Shouldn't this be using the focus ring color? I am not a fan of that gray outline if a caret selection will always look different from it.
Nikita Vasilyev
Comment 4 2018-06-25 10:33:17 PDT
(In reply to Brian Burg from comment #3) > Comment on attachment 343453 [details] > Patch > > Shouldn't this be using the focus ring color? I am not a fan of that gray > outline if a caret selection will always look different from it. This outline is only visible when hovering (with a mouse cursor). The focus ring may be shown elsewhere.
Blaze Burg
Comment 5 2018-06-25 10:36:40 PDT
Comment on attachment 343453 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-06-25 10:42:09 PDT
Comment on attachment 343453 [details] Patch Clearing flags on attachment: 343453 Committed r233156: <https://trac.webkit.org/changeset/233156>
WebKit Commit Bot
Comment 7 2018-06-25 10:42:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-25 10:45:42 PDT
<rdar://problem/41429310>
Note You need to log in before you can comment on or make changes to this bug.