Bug 186973 – [Cocoa] Improve ARC compatibility of more code in JavaScriptCore

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Darin Adler]

[Cocoa] Improve ARC compatibility of more code in JavaScriptCore

[Darin Adler]

Created attachment 343440 [details]
Patch

[Darin Adler]

Created attachment 343977 [details]
Patch

[Darin Adler]

Created attachment 344027 [details]
Patch

[Darin Adler]

Committed r233409: <https://trac.webkit.org/changeset/233409>

[Radar WebKit Bug Importer]

<rdar://problem/41699383>

[Keith Miller]

Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSContextInternal.h:33
> -    CallbackData *next;
> +    CallbackData* next;

I thought in Objective-C++ code we followed the Objective-C style of putting the * next to the variable name rather than our C++ style?

(In reply to Keith Miller from comment #6)
> Comment on attachment 344027 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344027&action=review
> 
> > Source/JavaScriptCore/API/JSContextInternal.h:33
> > -    CallbackData *next;
> > +    CallbackData* next;
> 
> I thought in Objective-C++ code we followed the Objective-C style of putting
> the * next to the variable name rather than our C++ style?

* placement depends on the type. For Objective-C classes, the * comes after the space.

[Darin Adler]

Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSVirtualMachine.mm:-190
> -        [ownedObjects release];

This change should not have been included in the patch, and was a mismerge. It introduced a storage leak fixed in bug 201803.