Bug 186973 - [Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Summary: [Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 221107
  Show dependency tree / graph
 
Reported: 2018-06-23 09:11 PDT by Darin Adler
Modified: 2021-01-28 14:58 PST (History)
13 users (show)

See Also:

Attachments
Patch (65.24 KB, patch)
2018-06-23 09:56 PDT, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
Patch (70.63 KB, patch)
2018-06-29 17:09 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (63.88 KB, patch)
2018-06-30 17:46 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-06-23 09:11:28 PDT 
[Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Comment 1 Darin Adler 2018-06-23 09:56:52 PDT 
Created attachment 343440 [details]
Patch
Comment 2 Darin Adler 2018-06-29 17:09:34 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2018-06-30 17:46:02 PDT 
Created attachment 344027 [details]
Patch
Comment 4 Darin Adler 2018-07-01 11:23:59 PDT 
Committed r233409: <https://trac.webkit.org/changeset/233409>
Comment 5 Radar WebKit Bug Importer 2018-07-01 11:24:48 PDT 
<rdar://problem/41699383>
Comment 6 Keith Miller 2018-07-01 11:49:16 PDT 
Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSContextInternal.h:33
> -    CallbackData *next;
> +    CallbackData* next;

I thought in Objective-C++ code we followed the Objective-C style of putting the * next to the variable name rather than our C++ style?
Comment 7 mitz 2018-07-01 12:14:37 PDT 
(In reply to Keith Miller from comment #6)
> Comment on attachment 344027 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344027&action=review
> 
> > Source/JavaScriptCore/API/JSContextInternal.h:33
> > -    CallbackData *next;
> > +    CallbackData* next;
> 
> I thought in Objective-C++ code we followed the Objective-C style of putting
> the * next to the variable name rather than our C++ style?

* placement depends on the type. For Objective-C classes, the * comes after the space.
Comment 8 Darin Adler 2019-09-15 10:47:02 PDT 
Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSVirtualMachine.mm:-190
> -        [ownedObjects release];

This change should not have been included in the patch, and was a mismerge. It introduced a storage leak fixed in bug 201803.